feat: pause_length{,_scale}をデフォルト値限定で受け入れる
#872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qryxip
force-pushed
the
feat-accept-default-pause-length-and-pause-length-scale
branch
from
4271275
to
63153a1
Compare
|
あ！ 無音調整 やったの @rokujyushi さんじゃなくて @X-20A さんですね。大変失礼いたしました。 |
qryxip
force-pushed
the
feat-accept-default-pause-length-and-pause-length-scale
branch
2 times, most recently
from
d2daaa5
to
df00650
Compare
VOICEVOX/voicevox_engine#1308 と VOICEVOX/voicevox_engine#1425 の一部 を参考にコードを書いた。 @Hiroshiba さんと以下の２名の許諾のもと、 VOICEVOX#874 にのっとりMITライセンスと してライセンスする。 * @X-20A (VOICEVOX/voicevox_engine#1308) * @sabonerune (VOICEVOX/voicevox_engine#1425) Co-Authored-By: X-20A <[email protected]> Co-Authored-By: sabonerune <[email protected]> Co-authored-by: Hiroshiba <[email protected]> Refs: VOICEVOX#874 (comment) Refs: VOICEVOX#874 (comment)
qryxip
force-pushed
the
feat-accept-default-pause-length-and-pause-length-scale
branch
from
df00650
to
c8deaad
Compare
Hiroshiba
approved these changes
Nov 22, 2024
|
todo一つだけ入れてマージしようと思います。 |
|
あ、Java忘れてた。まあ後で一緒にやれば… |
|
↑ 別に忘れてなかった。やったのを忘れたっぽい… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
AudioQueryにpause_length{,_scale}を追加する。ただしそれぞれnullと1.のみを許し、無音時間調整自体はまだ実装しない。関連 Issue
Refs: VOICEVOX/voicevox_engine#1308, VOICEVOX/voicevox_engine#1425
その他