Spec partition nonce functionality #149
Conversation
spec.bs
Outdated
| boolean |isCredentialless| and [=fenced frame config instance/partition nonce=] or null | ||
| |newFencedFrameNonce|: | ||
|
|
||
| 1. If |credentialless| is true, return |this|'s [=top-level browsing context=]'s |
There was a problem hiding this comment.
credentialless => isCredentialless
There was a problem hiding this comment.
I can't really change this, since it corresponds to an exposed IDL attribute.
https://wicg.github.io/anonymous-iframe/#spec-window-attribute
There was a problem hiding this comment.
Well where are you getting |credentialless| from then? It's not just a global variable is it?
There was a problem hiding this comment.
It's a local variable, but I meant it would be weird to call it something else when it corresponds exactly to this preexisting field, and the same name is used throughout the Iframe credentialless spec
There was a problem hiding this comment.
Where is this local variable defined? Sorry I don't think I'm getting it.
There was a problem hiding this comment.
Oh, I misread this. I didn't mean to name the variable isCredentialless above in the declaration. The iframe credentialless spec refers to this kind of variable as credentialless throughout, so it would be inconsistent naming to use isCredentialless here. Changed the declaration back to credentialless to match.
There was a problem hiding this comment.
So @VergeA what's the verdict here? Should we have a "credentialless" variable in the algorithm declaration? Does everything look good enough here to resolve?
There was a problem hiding this comment.
Yes, I believe the "credentialless" variable needs to be declared. Reasoning:
- The "process a navigate fetch" algorithm below already has a "credentialless" variable
- The "initialize a document object" algorithm below also already has a "credentialless" variable
Without it, we don't know whether the partition nonce should come from the credentialless iframe or the fenced frame.
Given that the algorithm here declares |credentialless| as a local variable, and the below algorithms invoke it correctly, this seems fine to me to resolve.
(going to resolve all the other comments before I re-request a review, just need to get this one out of my brain.)
spec.bs
Outdated
| boolean |isCredentialless| and [=fenced frame config instance/partition nonce=] or null | ||
| |newFencedFrameNonce|: | ||
|
|
||
| 1. If |credentialless| is true, return |this|'s [=top-level browsing context=]'s |
There was a problem hiding this comment.
Well where are you getting |credentialless| from then? It's not just a global variable is it?
|
@domfarolino I think all the comments are addressed now |
|
Hey y'all, this seems important to have for completeness of the network revocation spec, so I'm going to take it over from gtanzer. Looks like all outstanding comments have been addressed, but wanted to request a re-review for any additional feedback. If there's additional changes necessary, I'll address them before we merge (and also resolve all the merge conflicts :) ). |
spec.bs
Outdated
| boolean |isCredentialless| and [=fenced frame config instance/partition nonce=] or null | ||
| |newFencedFrameNonce|: | ||
|
|
||
| 1. If |credentialless| is true, return |this|'s [=top-level browsing context=]'s |
There was a problem hiding this comment.
So @VergeA what's the verdict here? Should we have a "credentialless" variable in the algorithm declaration? Does everything look good enough here to resolve?
|
I think most of this could use rewrapping. I think it rewraps too aggressively, avoiding all spaces in linked-to terms. |
|
Addressed all the outstanding comments, but still need to go back through and rewrap everything. |
|
Alright, this should be all rewrapped now. |
Preview | Diff