Updates from GitLab

[eveenhuis]

No description provided.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.70%. Comparing base (c0f3b7c) to head (a2e097c).

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #166   +/-   ##
=======================================
  Coverage   99.70%   99.70%           
=======================================
  Files          57       57           
  Lines        2375     2375           
=======================================
  Hits         2368     2368           
  Misses          7        7           

Flag	Coverage Δ
unittests	99.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[eveenhuis]

@bjrichardwebster CI is still running as I write this, but ghostflow has already failed. If CI fails on GitHub (after passing on GitLab) what do you want the resolution strategy to be? Hopefully it doesn't happen too often, but clearly it's not impossible

[bjrichardwebster]

@bjrichardwebster CI is still running as I write this, but ghostflow has already failed. If CI fails on GitHub (after passing on GitLab) what do you want the resolution strategy to be? Hopefully it doesn't happen too often, but clearly it's not impossible

When I was testing this out, I actually pushed to a PR to test it out actually, so I didn't catch this. What I thought about though in general is that there are required tests on github that we don't/can't have on gitlab, one of which is ghostflow. I believe that all of these will be very small fixes that the maintainers should be able to fix quickly. This ghostflow failure is an example where it is a bunch of trailing white space. That said, we should look at why all that exists and proprogate it back into devel-jatic when appropriate.