Include comments with template argument names in Cpp code from EmitC #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgehre-amd
reviewed
Nov 26, 2024
mgehre-amd
reviewed
Nov 26, 2024
mgehre-amd
reviewed
Nov 26, 2024
mgehre-amd
reviewed
Nov 26, 2024
mgehre-amd
reviewed
Nov 26, 2024
| emitArgs))) | ||
| return failure(); | ||
| if (callOpaqueOp.getTemplateArgNames() && | ||
| !callOpaqueOp.getTemplateArgNames()->empty()) { |
There was a problem hiding this comment.
I wonder whether we can remove the empty check here. We already know that they have the same number as template arguments (from the verifier).
There was a problem hiding this comment.
We made the default to be passing an empty AttrArray to the build method.
mgehre-amd
reviewed
Nov 26, 2024
| return emitOpError("number of template argument names must be equal to " | ||
| "number of template arguments"); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Can we please verify that we have no template arg names whenever we have no template args, and add a test for that?
|
Thank you! I added a small comments, but looks good overall. |
Co-authored-by: Corentin Ferry <[email protected]> Co-authored-by: Matthias Gehre <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.