Allow configuration of submodule.fetchJobs and fetch.parallel #1569
Conversation
| fi | ||
|
|
||
| echo "Testing fetchJobs exists" | ||
| git config --local --get-regexp submodules.fetchJobs | grep 10 |
There was a problem hiding this comment.
Is this the right way to test this?
| @@ -1,100 +1,104 @@ | |||
| name: 'Checkout' | |||
There was a problem hiding this comment.
I don't know why this shows this big diff, I thought it could be formatting but it doesnt seem like it.
There was a problem hiding this comment.
If you want to see the reason, I would suggest to run git show --word-diff --word-diff-regex=. 2bd5ef5487b953b5db186c7a68dcab4e4a8fe3fc -- action.yml - you will see that it had to do with the line endings (maybe something like e.g. https://docs.github.com/en/get-started/getting-started-with-git/configuring-git-to-handle-line-endings can be of help?)
README.md
Outdated
| # integer allows up to that number of submodules fetched in parallel. A value of 0 | ||
| # will give some reasonable default. If unset, it defaults to 1. | ||
| # Default: 1 | ||
| submodulesFetchJobs: '' |
There was a problem hiding this comment.
I was not sure about the name, if submoduleFetchJobs (aligned with git config) or submodulesFetchJobs (aligned with the other variable here)
There was a problem hiding this comment.
Not sure what that references
pecigonzalo
changed the title
| @@ -153,6 +153,7 @@ export async function getSource(settings: IGitSourceSettings): Promise<void> { | |||
|
|
|||
| // Fetch | |||
| core.startGroup('Fetching the repository') | |||
| await git.config('fetch.parallel', settings.fetchParallel.toString(), true) | |||
There was a problem hiding this comment.
Is this the right place to set it?
|
Any updates? |
|
Waiting for a maintainer to show 👍🏼 👎🏼 - I notice there are some conflicts, ill resolve them if I get the greenlight here. |
Resolves: #945
This PR aims to add support for
fetchJobsand enable parallel submodule cloning by leveraginggit config.Currently it uses--localconfig, but this could be switched to global.This improves clone times for some repositories that rely on submodules (if network conditions allow).
The tests did not seem to be able to run on my fork, I don't know if this is how it works or some mistake I made, so I opened the PR directly here.
fetch.parallel