Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[macOS] The macOS 12 Actions runner image will begin deprecation on 10/7/24 and will be fully unsupported by 12/3/24 for GitHub and ADO #10721

Open
3 of 14 tasks
erik-bershel opened this issue Oct 1, 2024 · 11 comments

Comments

@erik-bershel
Copy link
Contributor

Breaking changes

GitHub Actions is starting the deprecation process for macOS 12. While the image is being deprecated, You may experience longer queue times during peak usage hours. Deprecation will begin on 10/7/24 and the image will be fully unsupported by 12/3/24

To raise awareness of the upcoming removal, we will temporarily fail jobs using macOS 12. Builds that are scheduled to run during the brownout periods will fail. The brownouts are scheduled for the following dates and times:

  • November 4, 14:00 UTC - November 5, 00:00 UTC
  • November 11, 14:00 UTC - November 12, 00:00 UTC
  • November 18, 14:00 UTC - November 19, 00:00 UTC
  • November 25, 14:00 UTC - November 26, 00:00 UTC

Target date

December 3rd, 2024

The motivation for the changes

GitHub Actions maintains the latest two stable versions of any given OS version.

Possible impact

Workflows using the macos-12 image label will be terminated with an error.

Platforms affected

  • Azure DevOps
  • GitHub Actions

Runner images affected

  • Ubuntu 20.04
  • Ubuntu 22.04
  • Ubuntu 24.04
  • macOS 12
  • macOS 13
  • macOS 13 Arm64
  • macOS 14
  • macOS 14 Arm64
  • macOS 15
  • macOS 15 Arm64
  • Windows Server 2019
  • Windows Server 2022

Mitigation ways

Workflows using the macos-12 image label should be updated to macos-latest, macos-13, macos-14 or macos-15.

@erik-bershel erik-bershel pinned this issue Oct 1, 2024
vszakats added a commit to vszakats/curl that referenced this issue Oct 1, 2024
vszakats added a commit to curl/curl that referenced this issue Oct 1, 2024
- Days of `macos-12` are numbered:
  actions/runner-images#10721
  Drop 5 affected jobs, replaced by `macos-15` ones added earlier today.

- Drop Xcode 14 and 16 from `macos-14` jobs.
  Following up upstream announcement:
  actions/runner-images#10703
  (No active jobs are affected by this.)

Follow-up to 4b4ff44 #15108
Closes #15113
chrisbra pushed a commit to vim/vim that referenced this issue Oct 2, 2024
See: actions/runner-images#10721

closes: #15780

Signed-off-by: Philip H. <[email protected]>
Signed-off-by: Christian Brabandt <[email protected]>
@erik-bershel
Copy link
Contributor Author

Hey @jaimergp! I noticed that last time you bumped the version of macOS. I think https://github.com/conda-forge will be affected now as well.

@guyer
Copy link

guyer commented Oct 3, 2024

Somebody jumped the gun? Microsoft-hosted agents > Software already says macos-12 is "deprecated" and the macos-latest image just jumped from macos-12 to macos-14 between October 1st and October 2nd.

pcolby added a commit to pcolby/dokit that referenced this issue Oct 4, 2024
Because GitHub is about to deprecate macos-12, and macos-15 is
about to leave beta.

See actions/runner-images#10721
pcolby added a commit to pcolby/dokit that referenced this issue Oct 5, 2024
Also dropped the about-to-be-deprecated macos-12.

Squashed commit of the following:

commit 17e712b3346ac380132bd50d7071bac9768a1fa8
Author: Paul Colby <[email protected]>
Date:   Sat Oct 5 14:36:03 2024 +1000

    Restore the Linux and Windows builds

commit 17a4ddc
Author: Paul Colby <[email protected]>
Date:   Sat Oct 5 12:56:41 2024 +1000

    Correct a Qt version number

commit 42e7078
Author: Paul Colby <[email protected]>
Date:   Sat Oct 5 12:54:49 2024 +1000

    Extend the macOS timeout to 15 minutes

    Sometimes they take a bit longer to build.

commit f668de2
Author: Paul Colby <[email protected]>
Date:   Sat Oct 5 12:47:40 2024 +1000

    Restore the remaining macOS builds

commit 965ce30
Author: Paul Colby <[email protected]>
Date:   Sat Oct 5 12:46:03 2024 +1000

    Return to the macOS runner's provded CMake

commit 763026a
Author: Paul Colby <[email protected]>
Date:   Sat Oct 5 12:45:37 2024 +1000

    Exclude Qt 5.x and 6.2 with Clang on macOS 14+

commit 2887b8f
Author: Paul Colby <[email protected]>
Date:   Sat Oct 5 12:01:36 2024 +1000

    Determine which combinations are actually hanging

    So we can simply exclude them for now, subject to further testing
    on local hardware.

commit e15a9e9
Author: Paul Colby <[email protected]>
Date:   Sat Oct 5 11:49:18 2024 +1000

    Enable debugging via Qt's logging rules

commit 48defe8
Author: Paul Colby <[email protected]>
Date:   Sat Oct 5 11:40:36 2024 +1000

    Try a completely different test case

    Just to narrow down the test vs framework.

commit f810201
Author: Paul Colby <[email protected]>
Date:   Sat Oct 5 11:29:57 2024 +1000

    Correct the path to the test binary

commit d2f3924
Author: Paul Colby <[email protected]>
Date:   Sat Oct 5 11:23:43 2024 +1000

    Get more macOS debugging

commit 1e9617b
Author: Paul Colby <[email protected]>
Date:   Sat Oct 5 11:17:39 2024 +1000

    Reduce the timeout on macOS builds

    The default is 360 minutes, but the macOS jobs take ~5 minutes.

commit 309647d
Author: Paul Colby <[email protected]>
Date:   Sat Oct 5 10:57:21 2024 +1000

    Get some test debug info on macOS

commit ceb77f9
Author: Paul Colby <[email protected]>
Date:   Sat Oct 5 10:50:16 2024 +1000

    Clarify some comments

    Based on the info in this Qt blog post:
    https://www.qt.io/blog/qt-on-apple-silicon

commit ac1ce11
Author: Paul Colby <[email protected]>
Date:   Sat Oct 5 10:34:22 2024 +1000

    Use gcov 14 (with gcc 14)

commit b3a4436
Author: Paul Colby <[email protected]>
Date:   Sat Oct 5 10:25:33 2024 +1000

    Disable clang temporarily to test coverage builds

commit 3fc6b7a
Author: Paul Colby <[email protected]>
Date:   Fri Oct 4 22:36:02 2024 +1000

    Reinstate the macOS coverage builds

commit fede720
Author: Paul Colby <[email protected]>
Date:   Fri Oct 4 22:18:39 2024 +1000

    Restore the macOS clang builds

commit 735ac31
Author: Paul Colby <[email protected]>
Date:   Fri Oct 4 22:14:13 2024 +1000

    Skip some superfluous `echo` commands

commit 14dfeb6
Author: Paul Colby <[email protected]>
Date:   Fri Oct 4 22:07:38 2024 +1000

    Reinstace the Qt6 macOS gcc exclusions

    Since every one of those is still affected by QTBUG-107050.

    See https://bugreports.qt.io/browse/QTBUG-107050

commit 93be4da
Author: Paul Colby <[email protected]>
Date:   Fri Oct 4 21:49:43 2024 +1000

    Correct a step's output access syntax

commit e32b03b
Author: Paul Colby <[email protected]>
Date:   Fri Oct 4 21:39:18 2024 +1000

    Correct the `env.cc` reference

commit d507bb9
Author: Paul Colby <[email protected]>
Date:   Fri Oct 4 21:36:51 2024 +1000

    Restore the Qt 5.10 (QTBUG-66585) exclusion

commit 13c9f71
Author: Paul Colby <[email protected]>
Date:   Fri Oct 4 21:26:58 2024 +1000

    Correct workflow property name

commit 3f7365b
Author: Paul Colby <[email protected]>
Date:   Fri Oct 4 21:25:17 2024 +1000

    Correct a variable name

commit 4730ac1
Author: Paul Colby <[email protected]>
Date:   Fri Oct 4 21:23:01 2024 +1000

    Exclude macOS 14+ w/ gcc w/ Qt <6.2

commit aeae589
Author: Paul Colby <[email protected]>
Date:   Fri Oct 4 20:50:33 2024 +1000

    See if *any* gcc builds will pass on macOS 13+

commit ca87858
Author: Paul Colby <[email protected]>
Date:   Fri Oct 4 20:46:24 2024 +1000

    Derive the build ID's arch from the target archs

commit a337881
Author: Paul Colby <[email protected]>
Date:   Fri Oct 4 20:37:14 2024 +1000

    Remove the early exit

commit 51ffc8b
Author: Paul Colby <[email protected]>
Date:   Fri Oct 4 20:23:07 2024 +1000

    Correct the arch handling for gcc

commit f7f58ef
Author: Paul Colby <[email protected]>
Date:   Fri Oct 4 19:58:07 2024 +1000

    Choose the best available macOS arch

commit 271da5c
Author: Paul Colby <[email protected]>
Date:   Fri Oct 4 19:30:13 2024 +1000

    Assign CMAKE_OSX_ARCHITECTURES in its own step

    So we can add more logic to it shortly.

commit b342e39
Author: Paul Colby <[email protected]>
Date:   Fri Oct 4 18:38:57 2024 +1000

    Disable gcov builds for now

commit 2fa12aa
Author: Paul Colby <[email protected]>
Date:   Fri Oct 4 16:54:46 2024 +1000

    Try Qt's own CMake version

commit d715bb6
Author: Paul Colby <[email protected]>
Date:   Fri Oct 4 16:11:13 2024 +1000

    Disable Linux and Windows builds for now

    Just to speed up testing macOS on GitHub runners.

commit 40d1901
Author: Paul Colby <[email protected]>
Date:   Fri Oct 4 14:07:51 2024 +1000

    Try macos-15, and gcc-14 on macos runners

    Because GitHub is about to deprecate macos-12, and macos-15 is
    about to leave beta.

    See actions/runner-images#10721
masklinn added a commit to masklinn/maturin that referenced this issue Oct 5, 2024
The macos12 images [are deprecated and will be decommissioned by december](actions/runner-images#10721), jobs have started triggering warnings and brownouts are planned.

In my understanding this means the x86_64 wheels will be cross-compiled from the arm64 runners, but I understand cross compilation works fine. The x86_64 cross compilation is slower than the ARM64 compilation, but on my test project it's faster than the macos13 x86_64 build so that doesn't seem like a massive concern I feel?
masklinn added a commit to masklinn/maturin that referenced this issue Oct 5, 2024
The macos12 images [are deprecated and will be decommissioned by december](actions/runner-images#10721), jobs have started triggering warnings and brownouts are planned.

In my understanding this means the x86_64 wheels will be cross-compiled from the arm64 runners, but I understand cross compilation works fine. The x86_64 cross compilation is slower than the ARM64 compilation, but on my test project it's faster than the macos13 x86_64 build so that doesn't seem like a massive concern I feel?
austinvazquez added a commit to austinvazquez/containerd that referenced this issue Oct 7, 2024
This change upgrades the runner images in CI to macOS 13. macOS 12
runners are being deprecated.

See actions/runner-images#10721 for more
information.

Signed-off-by: Austin Vazquez <[email protected]>
crbelaus added a commit to crbelaus/difftastic that referenced this issue Nov 25, 2024
MacOS 12 runners are deprecated [1] so we need to use MacOS 14. By
default MacOS 14 runners are ARM based but we can use the MacOS 14 large
runners which are still Intel based.

[1]: actions/runner-images#10721
[2]: https://github.com/actions/runner-images
crbelaus added a commit to crbelaus/difftastic that referenced this issue Nov 25, 2024
MacOS 12 runners are deprecated [1] so we need to use MacOS 14. By
default MacOS 14 runners are ARM based but we can use the MacOS 14 large
runners which are still Intel based.

[1]: actions/runner-images#10721
[2]: https://github.com/actions/runner-images
justinvp added a commit to pulumi/pulumi-dotnet that referenced this issue Nov 25, 2024
actions/runner-images#10721:

> GitHub Actions is starting the deprecation process for `macOS 12`. While the image is being deprecated, You may experience longer queue times during peak usage hours. Deprecation will begin on 10/7/24 and the image will be fully unsupported by 12/3/24
>
> To raise awareness of the upcoming removal, we will temporarily fail jobs using `macOS 12`. Builds that are scheduled to run during the brownout periods will fail. The brownouts are scheduled for the following dates and times:
>
> * November 4, 14:00 UTC - November 5, 00:00 UTC
> * November 11, 14:00 UTC - November 12, 00:00 UTC
> * November 18, 14:00 UTC - November 19, 00:00 UTC
> * November 25, 14:00 UTC - November 26, 00:00 UTC
>
> ### Target date
> December 3rd, 2024
madsmtm added a commit to madsmtm/objc2 that referenced this issue Nov 25, 2024
macOS 12 is deprecated by GitHub actions:
actions/runner-images#10721
digit-google added a commit to digit-google/ninja that referenced this issue Nov 25, 2024
This updates `macos.yml` to use `macos-13` instead of
`macos-12`.

macos-12 is deprecated and results in longer queue times
during peak hours. In practice, also failed builds.

For details, see actions/runner-images#10721
star-hengxing added a commit to xmake-io/xmake-repo that referenced this issue Nov 25, 2024
AlexTMjugador added a commit to shssoichiro/oxipng that referenced this issue Nov 25, 2024
macOS 12 runners are scheduled for removal by GitHub: actions/runner-images#10721
leezer3 added a commit to leezer3/OpenBVE that referenced this issue Nov 25, 2024
mkruskal-google pushed a commit to protocolbuffers/protobuf that referenced this issue Nov 25, 2024
mkruskal-google added a commit to protocolbuffers/protobuf that referenced this issue Nov 25, 2024
* Fixed `NAN`/`INFINITY` definitions to work on Windows 11 SDK.

Fixes: #17308, #17238

Confirmation that this addresses the issue: grpc/grpc#37210 (comment)

PiperOrigin-RevId: 652541857

* Fix compilation in Clang C23 mode.

In C23, `false` is now of type `bool`, not `int`. This turned a couple places where `false` was returned instead of `NULL` into errors.

The workaround in upb for Windows's broken NAN macro causes an error in Clang under C23, `cannot compile this static initializer yet`, I believe because `0.0 / 0.0` is not valid in constant-evaluation. This seems like it's probably a legitimate result of C23 standardizing constexpr, although it _could_ be a clang bug. In any case, refine the workaround a bit, to avoid this problem.

I've also reverted the kUpb_FltInfinity/kUpb_Infinity back to their former definitions, as INFINITY wasn't broken by the windows header, only NAN.

PiperOrigin-RevId: 683152452

* Fix const INFINITY issue on MSVC.

We previously hit this for NAN, but it appears the latest version of MSVC used in windows github runners has the same issue for INFINITY.  The same strategy can be applied here.

This will be backported to fix broken release branches.

PiperOrigin-RevId: 699390594

* Regenerate stale files

* Update GitHub Actions to use macOS-13 ahead of macOS-12 deprecation.

See actions/runner-images#10721.

PiperOrigin-RevId: 684546079

* Pin to python 3.12 in upb/macos tests.

Python 3.13 seems to have some issues with our dependencies and both numpy and setuptools fails to install.

PiperOrigin-RevId: 689955916

* Fix bad cherry-pick

---------

Co-authored-by: Joshua Haberman <[email protected]>
Co-authored-by: Protobuf Team Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants