Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove toolchain directories from the cache. #437

Closed
wants to merge 0 commits into from

Conversation

dsame
Copy link
Contributor

@dsame dsame commented Oct 24, 2023

Description:
Since the toolchains were added in 1.21 the setup action populates the modules caching directory before it is restored from
the cache and prevents the tar from unpacking the archive.

This PR removes the toolchain directories from the cache allowing the tar to unpack the archive.

Related issue:
link to the related issue.

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@dsame dsame self-assigned this Oct 24, 2023
@dsame dsame linked an issue Oct 24, 2023 that may be closed by this pull request
5 tasks
);
return false;
export function getToolchainDirectoriesFromCachedDirectories(goVersion: string, cacheDirectories: string[]): string[] {
const re = new RegExp(`^toolchain@v[0-9.]+-go${goVersion}\.`)

Check failure

Code scanning / CodeQL

Useless regular-expression character escape

The escape sequence '\.' is equivalent to just '.', so the sequence may still represent a meta-character when it is used in a [regular expression](1).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant