-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce navigation stream #3538
feat: introduce navigation stream #3538
Conversation
6466b8f
to
643cd98
Compare
Hi @andiwand - I've changed this quite a bit, so here's a summary to guide you:
This is pretty much along the lines that you requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
One question: I wonder if we want to re-converge Core/Navigation
and Core/Propagator
since we accumulate stepping, navigation and propagation there. I feel like splitting out Navigation
requires also to split out Stepping
.
@andiwand - had a problem with the doc run, so I had to push another commit |
All fine, I think we can move it back to |
6ea9437
to
a40b6de
Compare
Quality Gate passedIssues Measures |
This PR introduces a
NavigationStream
object and a corresponding helper.The
NavigationStream
should build the backbone of the Gen3 navigator, with having aTargetStream
and aGeometryStream
to deal with.For details of the ongoing discussion, please see #3526.
@paulgessinger @andiwand