-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for PUID/PGID to Docker. #18
base: master
Are you sure you want to change the base?
Conversation
no user creation needed if you use su-exec and specify the UID and GID directly
you could set ENV=1000 instead of using default value in bash variable |
you can also user |
Oh cool I didn't know about su-exec, I'll update the branch to use that methodology instead. EDIT: ok the branch has been updated to use su-exec. I also forgot to chown the app folders so I fixed that too. |
Hi Sorry for the delay. Got tied up with some work. Thanks a lot for this. Let me test this locally and merge this. |
Hey Any chance to have this merged? This option seems necessary to make Podgrab work with NFS shares (or at least to make it work in my setup 😛). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, would be great to get this merged! It's been more than a year already!
Any updates? Its been over 3 years now... |
Adds support for changing the UID and GID at runtime by executing the app from a wrapper script that creates a container user with the appropriate UID/GID. Also updates the documentation to reflect the two new variables. I built an image based on this that's available for testing at spencerhughes/podgrab.
Fixes for #16 #12