fix: update entity with HA 2024.11 #1069
Merged
+2,242
−1,916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehendrix23
changed the title
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With HA 2024.11 a new attribute update_percentage is introduced and attribute in_progress is now set to only return a boolean.
As per Home Assistant development guide for update entity https://developers.home-assistant.io/docs/core/entity/update/ in_progress attribute should only return True or False and not a value on current installation progress.
Attribute update_percentage should be used to return current % of the installation or None.
This PR updates the logic for in_progress attribute to ensure it only returns True or False. New attribute update_percentage is added to show current progress if installing or None if update is not happening.
Breaking Change