Update docker registry to twun.io's registry chart

[Shikachuu]

Signed-off-by: Czékus Máté [email protected]

Description

Docker Registry used the old stable chart which was outdated and the only still updated 1:1 feature comaptible one was twuni's chart.

Motivation and Context

• I have raised an issue to propose this change, which has been given a label of design/approved by a maintainer (required) Notice: the stable Helm charts have been deprecated, new alternatives are required #274

How Has This Been Tested?

Manually by running arkade install docker-registry with all the flags.

Are you a GitHub Sponsor yet (Yes/No?)

• Yes
• No

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Documentation

• I have updated the list of tools in README.md if (required) with ./arkade get -o markdown
• I have updated the list of apps in README.md if (required) with ./arkade install --help

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I've read the CONTRIBUTION guide
• I have signed-off my commits with git commit -s
• I have added tests to cover my changes.
• All new and existing tests passed.

• I have tested this on arm, or have added code to prevent deployment

[alexellis]

What can you tell us about twun.io? Who runs it and maintains it?

[Shikachuu]

What can you tell us about twun.io? Who runs it and maintains it?

This is the github page for this project: https://github.com/twuni/docker-registry.helm
Also this was the only 1:1 feature compatible, still maintained solution that I could find, perhaps one of the project owners tell us more about them. @canterberry

[canterberry]

Thanks for the tag @Shikachuu!

The twun.io domain is privately held and operated by myself, primarily for package distribution under appropriate subdomains (helm.twun.io among them). As you can see, there's no HTTP front-end of consequence at the parent domain.

This chart is also available via a GitHub-owned domain (see twuni/docker-registry.helm#22 (comment) for details), so if you prefer, you can use https://twuni.github.io/docker-registry.helm. I dual-publish each release to both repos, with provenance, and intend to continue supporting both. FWIW, of the two URLs, the GitHub-owned one is more likely to transition toward community governance one day.

My primary goals for maintaining this chart are:

• to maintain compatibility with users of the stable chart
• to ensure compatibility with modern Docker+Helm+Kubernetes tooling
• to fix any defects

So if you're using the stable chart, you should be fine updating to this one.

[canterberry]

Offering my approval, as the changeset LGTM.

[alexellis]

I spoke to @justincormack at Docker, and it seems like there is no official Helm chart for the OSS registry.

So therefore, as discussed on Discord @Shikachuu, please:

• Make it very clear in the command help messages that this is a community chart, not "official"
• Use the GitHub publishing address instead
• Link to @canterberry's GitHub repo in the post-installation notes and in the help message

Once you have that arranged, I'll merge this PR.

@canterberry out of interest, is there still support for ARM architectures?

[canterberry]

I appreciate the diligence, @alexellis ! All correct, to my knowledge.

As for ARM support: I think that depends exclusively on the image and whether it's built for ARM architecture. The chart supports custom images, so even if there wasn't an official ARM-compatible image, one could in theory compile (or locate) one and reference that instead.

I haven't seen any ARM-related changes come through in the chart, so should be status quo. Feel free to create an issue in twuni/docker-registry.helm if there's a compatibility issue we might be able to resolve in the chart.

[derek]

Thank you for your contribution. unfortunately, one or more of your commits are missing the required "Signed-off-by:" statement. Signing off is part of the Developer Certificate of Origin (DCO) which is used by this project.

Read the DCO and project contributing guide carefully, and amend your commits using the git CLI. Note that this does not require any cryptography, keys or special steps to be taken.

💡 Shall we fix this?

This will only take a few moments.

First, clone your fork and checkout this branch using the git CLI.

Next, set up your real name and email address:

git config --global user.name "Your Full Name"
git config --global user.email "[email protected]"

Finally, run one of these commands to add the "Signed-off-by" line to your commits.

If you only have one commit so far then run: git commit --amend --signoff and then git push --force.
If you have multiple commits, watch this video.

Check that the message has been added properly by running "git log".

[Shikachuu]

I spoke to @justincormack at Docker, and it seems like there is no official Helm chart for the OSS registry.

So therefore, as discussed on Discord @Shikachuu, please:

* Make it very clear in the command help messages that this is a community chart, not "official"

* Use the GitHub publishing address instead

* Link to @canterberry's GitHub repo in the post-installation notes and in the help message

Once you have that arranged, I'll merge this PR.

@canterberry out of interest, is there still support for ARM architectures?

Done ✔️

[alexellis]

LGTM

[alexellis]

Thank you both. @canterberry your input is very much appreciated

If you're interested in linking back to arkade install docker-registry from your docs / README, it's a very quick and convenient way to do an automated / 1-line installation with auth/tls.

https://blog.alexellis.io/get-a-tls-enabled-docker-registry-in-5-minutes/