Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ai fallback #1541

Merged
merged 4 commits into from
Nov 25, 2024
Merged

fix ai fallback #1541

merged 4 commits into from
Nov 25, 2024

Conversation

johnlanni
Copy link
Collaborator

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.

Project coverage is 43.44%. Comparing base (ef31e09) to head (fac9b72).
Report is 207 commits behind head on main.

Files with missing lines Patch % Lines
pkg/ingress/config/ingress_config.go 0.00% 20 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1541      +/-   ##
==========================================
+ Coverage   35.91%   43.44%   +7.53%     
==========================================
  Files          69       76       +7     
  Lines       11576    12323     +747     
==========================================
+ Hits         4157     5354    +1197     
+ Misses       7104     6633     -471     
- Partials      315      336      +21     
Files with missing lines Coverage Δ
pkg/ingress/config/ingress_config.go 12.94% <0.00%> (-0.93%) ⬇️

... and 68 files with indirect coverage changes

---- 🚨 Try these New Features:

Copy link
Collaborator

@CH3CHO CH3CHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnlanni johnlanni merged commit a759338 into alibaba:main Nov 25, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants