-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support OpenAI embedding. #1542
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: duxin40 <[email protected]>
Signed-off-by: duxin40 <[email protected]>
Signed-off-by: duxin40 <[email protected]>
duxin40 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
@CH3CHO 辛苦有时间帮忙review下~ |
好的。预计今天能给出 review 意见。另外麻烦先签署一下 CLA。谢谢! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
Ⅰ. Describe what this PR did
This PR is to support openai embedding.
Ⅱ. Does this pull request fix one issue?
Fix #1443.
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
docker-compose.yaml:
envoy.yaml:
request:
embedding response log:
Ⅴ. Special notes for reviews