Skip to content
This repository has been archived by the owner on May 24, 2020. It is now read-only.

Enhancement/foil #28

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Enhancement/foil #28

wants to merge 9 commits into from

Conversation

dev-id
Copy link
Contributor

@dev-id dev-id commented Jun 21, 2016

Adds foil overlay. Applies foil overlay to masters packs (1 per pack) and randomly inserts into all other sets (including pre-foil sets)

Potential Issues:

  • Brings to light this bug https://github.com/aeosynth/draft/issues/146 because of the higher occurrence of multiple of the same card in a pack
  • Autopick/hover overlay overrides foil background overlay
  • Foil card is not sorted at end of pack (rarity-wise) as it would be in a real pack

@dev-id
Copy link
Contributor Author

dev-id commented Jun 21, 2016

#14

@dev-id dev-id closed this Jun 21, 2016
@dev-id dev-id reopened this Jun 23, 2016
@arxanas
Copy link
Owner

arxanas commented Sep 26, 2016

Is this PR ready to be merged?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants