-
-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: all ticket types are rendered #403
Conversation
✅ Deploy Preview for peaceful-ramanujan-288045 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hey @NamanSriva the changes look good, could you just make it so that the active tickets are on top in the mobile view and others below it. cc: @AceTheCreator , this looks way suitable to our design in my opinion. |
@ashmit-coder sure I'll do it ASAP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome changes @NamanSriva but wouldn't it be even better if tickets renders in carousel?
Also disable/reduce the overlay effect onHover
I do agree on the overlay effect. about the carousel, ig it will make sense considering uniformity. So yeah a carousel sounds good , but just in desktop view. |
e6a9f88
to
cc5c6aa
Compare
Hey @NamanSriva why did you close the pr? |
@ashmit-coder actually there was error in naming the branch and it failed some tests while doing commit. |
Okay so you reopening another pr? |
fix: This PR fixes the ways tickets are being rendered. Earlier only upcoming tickets were rendered but now all the tickets including ended or upcoming are rendered and displayed some more info about tickets(description). Also improved the UI so that while hovering tickets do not overlap on each other.
Related issue(s)
Fixes #395