-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: finish migrating to react renderer #398
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
Can you review this PR,
so that i can proceed with this cc @derberg |
The cc @derberg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good progres
left some suggestions
Quality Gate passedIssues Measures |
done the reviewed changes @derberg |
pinging you again cc @derberg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! did you try to use the template using https://github.com/asyncapi/nodejs-ws-template?tab=readme-ov-file#how-to-use-the-template instruction? I mean the react version?
when running ag
command you need to reference local copy of react based template instead of @asyncapi/nodejs-ws-template
Description
Updated this template to use react renderer
Related issue(s)
#294