-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: patch @semaphore-protocol/data to return result sorted by timestamp #492
Conversation
…imestamp Patch @semaphore-protocol/data so that getGroups return results sorted by creation time
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks great. Thank you very much ✨
I just left one comment.
.yarn/patches/@semaphore-protocol-data-npm-3.10.0-48e6c0f59e.patch
Outdated
Show resolved
Hide resolved
.yarn/patches/@semaphore-protocol-data-npm-3.10.0-48e6c0f59e.patch
Outdated
Show resolved
Hide resolved
@waddaboo thanks. Can you run |
@vplasencia Oops missed that. Pushed! :) |
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2024 Bandada Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
Description
This PR aims to patch @semaphore-protocol/data so that
getGroups
in dashboard will return results sorted by creation time in descending methodRelated Issue
#433
Does this introduce a breaking change?