Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: patch @semaphore-protocol/data to return result sorted by timestamp #492

Merged
merged 5 commits into from
Apr 30, 2024

Conversation

waddaboo
Copy link
Collaborator

@waddaboo waddaboo commented Apr 29, 2024

Description

This PR aims to patch @semaphore-protocol/data so that getGroups in dashboard will return results sorted by creation time in descending method

Related Issue

#433

Does this introduce a breaking change?

  • Yes
  • No

…imestamp

Patch @semaphore-protocol/data so that getGroups return results sorted by creation time
Copy link

vercel bot commented Apr 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bandada-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 29, 2024 4:26pm

Copy link
Member

@vplasencia vplasencia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great. Thank you very much ✨

I just left one comment.

@vplasencia
Copy link
Member

vplasencia commented Apr 29, 2024

@waddaboo thanks. Can you run yarn and push the changes to update the yarn.lock file?

@waddaboo
Copy link
Collaborator Author

@vplasencia Oops missed that. Pushed! :)

@vplasencia vplasencia changed the base branch from main to dev April 30, 2024 07:24
@vplasencia vplasencia merged commit a5d073b into bandada-infra:dev Apr 30, 2024
4 checks passed
Copy link

gitpoap-bot bot commented Apr 30, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2024 Bandada Contributor:

GitPOAP: 2024 Bandada Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@waddaboo waddaboo deleted the issue-433 branch April 30, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants