Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ecdsa sign would return r as a BN.js instance #3817

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: ecdsa sign would return r as a BN.js instance #3817

wants to merge 1 commit into from

Conversation

r4mmer
Copy link

@r4mmer r4mmer commented Nov 1, 2024

Description

The Q.x would return a BN without bitcore-lib's methods, this is avoided by calling getX instead which converts to the appropriate instance.

@kajoseph
Copy link
Collaborator

kajoseph commented Nov 5, 2024

Q.x is an instance of ./bn.js since ./bn.js is a monkey patch of the dependency bn.js. At the point of your change Q.x instanceof BN is true and has the monkey patched methods on it. What's your usage?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@r4mmer @kajoseph