test: Delayed Prevote Prototype #1460
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergio-mena
reviewed
Sep 6, 2024
| @@ -942,6 +946,8 @@ func (cs *State) handleTimeout(ti timeoutInfo, rs cstypes.RoundState) { | |||
|
|
|||
| cs.enterPrevote(ti.Height, ti.Round) | |||
|
|
|||
| case cstypes.RoundStepDelaydPrevote: | |||
| cs.enterPrevote(ti.Height, ti.Round) | |||
There was a problem hiding this comment.
Shouldn't you call doPrevotehere?
If you call enterPrevote here again, the defer in method enterPrevote will be called twice. Not catastrophic, but there'll be a few duplicated events that may confuse external observers (e.g., relayers)
There was a problem hiding this comment.
Thanks @sergio-mena for your comment, you are right, the duplicate events needs to be considered carefully which is not yet the case in the current prototype implementation. But, will certainly address this in the full version.
|
Closing this as the results from delayed precommit experiments [see this] were promising, hence pursuing delayed prevotes wouldn't be necessary at this point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.