Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REL: 3.3.1 Bugfix release #2524

Merged
merged 1 commit into from
Sep 3, 2024
Merged

REL: 3.3.1 Bugfix release #2524

merged 1 commit into from
Sep 3, 2024

Conversation

sebix
Copy link
Member

@sebix sebix commented Aug 27, 2024

blocked by #2522 and #2523

The release dates need to be entered in NEWS and CHANGELOG before merging

@sebix sebix added this to the 3.3.1 milestone Aug 27, 2024
CHANGELOG.md Outdated
@@ -9,15 +9,9 @@
3.3.1 (unreleased)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am missing the list of new things which work or were changed (i.e. shadowserver config parser -> empty string -> by default select all reports.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file contains exactly that list, 10 lines below.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait, I thought that's known bugs. Let me double check. Maybe I read the diffs too fast?

Damn, I did :) okay, then we are fine.

@sebix sebix marked this pull request as ready for review September 3, 2024 07:47
@sebix
Copy link
Member Author

sebix commented Sep 3, 2024

Rebased on develop and now ready to be merged after approval

Copy link
Member

@aaronkaplan aaronkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good. thanks! Let's go.

CHANGELOG.md Outdated
@@ -9,15 +9,9 @@
3.3.1 (unreleased)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait, I thought that's known bugs. Let me double check. Maybe I read the diffs too fast?

Damn, I did :) okay, then we are fine.

@sebix sebix merged commit ceb678c into develop Sep 3, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants