Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add issue templates #6986

Merged

Conversation

ShortDevelopment
Copy link
Contributor

@ShortDevelopment ShortDevelopment commented Apr 22, 2024

Add issue templates (forms) to...

  • guide authors during issue creation and
  • automatically assign labels

Example: .NET runtime
Tools: Issue Form Creator


See Creating issue forms
See Syntax for issue forms

@ppenzin

@rhuanjl
Copy link
Collaborator

rhuanjl commented Apr 23, 2024

@ppenzin what do you think of this? I like the idea in theory but have little experience of how well these sorts of templates work in practise.

@ppenzin
Copy link
Member

ppenzin commented May 1, 2024

@rhuanjl this would pre-populate issue fields from one of the provided templates, it can be useful. The balance of low level vs high level in these can be sometimes hard to find.

Copy link
Member

@ppenzin ppenzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good. Not sure about dedicated JSRT feature/bug template, but don't feel strongly either way.

.github/ISSUE_TEMPLATE/03-jsrt-bug.yaml Outdated Show resolved Hide resolved
Comment on lines +3 to +5
- name: Discord
url: https://discord.gg/dgRawPdNuC
about: If you have any questions, feel free to join our Discord server.
Copy link
Contributor Author

@ShortDevelopment ShortDevelopment May 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, there's no template for questions but a discord link instead.
Should I add one?

@ShortDevelopment
Copy link
Contributor Author

I've temporarily switched the default branch of my fork so you can preview how those templates would look like.
https://github.com/ShortDevelopment/ChakraCore/issues/new/choose

@rhuanjl rhuanjl merged commit 3a7b120 into chakra-core:master May 23, 2024
24 checks passed
@ShortDevelopment ShortDevelopment deleted the feature/github/issue-templates branch August 17, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants