fix: S-interpolator for assert, assume and printf #3103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SingularityKChen
force-pushed
the
fix-S-interpolator
branch
from
8114f46
to
f2d378a
Compare
Merged
|
@SingularityKChen rebase to master plz |
SingularityKChen
force-pushed
the
fix-S-interpolator
branch
from
e5e2765
to
43b2860
Compare
sequencer
force-pushed
the
fix-S-interpolator
branch
2 times, most recently
from
09e9f56
to
86ae343
Compare
SingularityKChen
force-pushed
the
fix-S-interpolator
branch
from
86ae343
to
bd46bd5
Compare
|
LGTM, but I'm not so familiar with printf API, @jackkoenig for review&approve. |
SingularityKChen
force-pushed
the
fix-S-interpolator
branch
from
bd46bd5
to
8e42181
Compare
sequencer
approved these changes
Jun 15, 2023
| assert(!q.enq.valid, s"ID ${i} should not be used") | ||
| chisel3.assert(!q.enq.valid, "ID ${i} should not be used") |
There was a problem hiding this comment.
I don't think this is correct.
sequencer
requested changes
Jun 15, 2023
| @@ -73,7 +73,8 @@ class TLPatternPusher(name: String, pattern: Seq[Pattern])(implicit p: Parameter | |||
| } | |||
|
|
|||
| val (plegal, pbits) = pattern.map(_.bits(edgeOut)).unzip | |||
| assert (end || VecInit(plegal)(step), s"Pattern pusher ${name} tried to push an illegal request") | |||
| val msg = s"Pattern pusher $name tried to push an illegal request" | |||
| assert(end || Vec(plegal)(step), msg) | |||
There was a problem hiding this comment.
VecInit?
Suggested change
| assert(end || Vec(plegal)(step), msg) | |
| assert(end || VecInit(plegal)(step), msg) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: chipsalliance/chisel#2751
Type of change: bug report
Impact: no functional change
Development Phase: implementation
Release Notes