Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: a helper to implement ccc base class #81

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

homura
Copy link

@homura homura commented Oct 20, 2024

This PR introduces the Base class for CCC and a helper function to implement the required methods, including static fromBytes, toBytes, clone, hash, and eq. As an transition program, it works well with molecule-es and @ckb-lumos/codec to reduce boilerplate code

Copy link

changeset-bot bot commented Oct 20, 2024

⚠️ No Changeset found

Latest commit: c56389a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@homura homura changed the title feat: a macro to implement ccc base class feat: a helper to implement ccc base class Oct 21, 2024
@homura homura mentioned this pull request Oct 21, 2024
3 tasks
@homura homura marked this pull request as ready for review November 4, 2024 13:35
@Keith-CY
Copy link

Keith-CY commented Nov 4, 2024

Please have a review @Hanssen0

@ashuralyk
Copy link
Contributor

@homura if use molecule in ccc, molecule-es is required for now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants