-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce session setup #422
base: main
Are you sure you want to change the base?
Conversation
Agree with you on this one - it's DB specific so can/should just go in the DB's config directory. However, there are a few places where we do have non-DB specific files in that data directory (e.g., templated example config). Could just duplicate them or find another place to put them. |
@ranaalotaibiMS , #416 and other recent PRs introduced a lot of changes, especially around standardizing code formatting, so you'll have to rebase your changes on an updated main branch first. |
34c1bcb
to
ed730c6
Compare
@bpkroth : Rebased |
@@ -10,6 +10,8 @@ | |||
<reconnectOnConnectionFailure>true</reconnectOnConnectionFailure> | |||
<isolation>TRANSACTION_SERIALIZABLE</isolation> | |||
<batchsize>1024</batchsize> | |||
<!-- Session setup statements file --> | |||
<!-- <sessionsetupfile>config/sqlserver/session_setup_sqlserver_cmds_example.sql</sessionsetupfile> --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Request that we have at least one example config where this option is not commented out so that it runs during the CI tests and/pr add an explicit unit test for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ranaalotaibiMS bump :)
@ranaalotaibiMS, seems like there are some missing formatting changes. Can you please address those along with the requested example config for testing changes? Thanks! |
This PR introduces functionality for configuring a session by executing predefined statements before the benchmark execution begins. Users should specify the file containing these statements within the tag
<sessionsetupfile> </sessionsetupfile>
in the benchmarks' config files. CC: @bpkrothFor example,