-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bn] Merge dev-bn
branch into main
branch
#3301
base: main
Are you sure you want to change the base?
Conversation
[bn] Localize Contribute and Contributor Ladder
[bn] changes in file of contributor & contributor ladder
[bn] Localize content\bn\_TEMPLATE.md
Apply CODEOWNERS updates in main to dev-bn
[bn] Localize `content/bn/style-guide/_index.md `
[bn] Updated content/bn/style-guide/_index.md
[bn] Update `content/bn/style-guide/_index.md`
[bn] Updated the _index.md
Signed-off-by: Asem Hamid <[email protected]>
Signed-off-by: Asem Hamid <[email protected]>
Signed-off-by: Asem Hamid <[email protected]>
[bn] Update dev-bn branch with main
[bn] fix typo in bn.toml
[bn] fix typo /bn/zero-trust-architecture.md
[bn] Update links microservice > microservice-architecture
…ering [bn] Fix SRE link in security-chaos-engineering.md
…ecture (#3284) Signed-off-by: Asem Hamid <[email protected]>
[bn] Update containerization.md
…pe's-observability-section"-link [bn] Update cloud native landscape's observability section link
Signed-off-by: Asem Hamid <[email protected]>
Signed-off-by: Sajib Adhikary <[email protected]> Signed-off-by: Asem Hamid <[email protected]> Co-authored-by: Asem Hamid <[email protected]>
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@sajibAdhi , The dev-bn branch is behind a lot of changes, and several files need to be updated. /hold , until then |
Wait, please do not proceed with this yet. |
Wait, please do not proceed with this yet. |
To who merge this PR: please use 'Squash and merge' method when merging. |
Signed-off-by: Asem Hamid <[email protected]>
@asem-hamid do you have a plan to unhold this PR? @sajibAdhi just hope to let you know, this PR has many meaningless commits considering the number of changed files. We recommend localization approvers handle commit history well. (make a localization PR has one commit if possible). Please share this to he team approves. :) FYI, This PR will be merged by squash merge method. |
@seokho-son No, actually, we are quite behind. We have a small team, so we have to move forward slowly. Also, we are trying to follow the '1 commit per PR' rule now. However, those meaningless commits are there for historical reasons. In the early days, the team didn't follow the '1 commit per PR' policy strictly, so the As a result, when we merge the To break this cycle, we can take the following step: After merging this PR (by squash method), we can simply delete the Please correct me if I’m wrong and share your opinion. |
Describe your changes
Merge the
dev-bn
branch into themain
branch.Related issue number or link (ex:
resolves #issue-number
)#410
Checklist before opening this PR (put
x
in the checkboxes)git commit -s
) is to affirm that commits comply DCO. If you are working locally, you could add an alias to yourgitconfig
by runninggit config --global alias.ci "commit -s"
.