wip

code-pushup · Aug 19, 2024 · b34a052 · b34a052
1 parent 744af95
commit b34a052
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/tools/src/verdaccio/README.md b/tools/src/verdaccio/README.md
@@ -1,7 +1,8 @@
 # TODO
 
+- in the future the root project has no verdaccio target anymore. only e2e projects have a verdaccio target.
 - Use `.npmrc` form e2e folder
-- move uniquePort into project targets
+- move uniquePort into project targets of e2e projects
 
 https://verdaccio.org/docs/setup-npm#specific
 

diff --git a/tools/src/verdaccio/verdaccio.plugin.ts b/tools/src/verdaccio/verdaccio.plugin.ts
@@ -8,7 +8,6 @@ import { type ProjectConfiguration } from 'nx/src/config/workspace-json-project-
 import { uniquePort } from './utils';
 
 type CreateNodesOptions = {
-  // @TODO move into target options
   port?: string | number;
   config?: string;
   storage?: string;
@@ -36,7 +35,6 @@ export const createNodes: CreateNodes = [
       projectConfigurationFile,
     );
 
-    // @TODO in the future the root project has no verdaccio target anymore. only e2e projects have.
     const isRootProject = root === '.';
     if (!isRootProject) {
       return {};
@@ -49,7 +47,6 @@ export const createNodes: CreateNodes = [
             port,
             config,
             storage,
-            verbose,
             preTargets,
           }),
         },
@@ -63,7 +60,7 @@ function verdaccioTargets({
   config,
   storage,
   preTargets,
-}: Required<CreateNodesOptions>) {
+}: Required<Omit<CreateNodesOptions, 'verbose'>>) {
   const targets = Array.isArray(preTargets) ? preTargets : [preTargets];
   return {
     'start-verdaccio': {