-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: local registry #798
Conversation
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared target commit bece330 with source commit f8f6b74. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories👍 1 group improved, 👎 3 groups regressed, 👍 5 audits improved, 👎 3 audits regressed, 13 audits changed without impacting score🗃️ Groups
16 other groups are unchanged. 🛡️ Audits
489 other audits are unchanged. |
# Conflicts: # global-setup.e2e.ts # tools/scripts/publish.plugin.ts # tools/scripts/start-local-registry.ts # tools/scripts/utils.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the documentation effort 👍 Due to the size of this PR I have a lot of comments 😅
Co-authored-by: Matěj Chalk <[email protected]>
Co-authored-by: Matěj Chalk <[email protected]>
Co-authored-by: Matěj Chalk <[email protected]>
Co-authored-by: Matěj Chalk <[email protected]>
Co-authored-by: Matěj Chalk <[email protected]>
Co-authored-by: Matěj Chalk <[email protected]>
Co-authored-by: Matěj Chalk <[email protected]>
Co-authored-by: Matěj Chalk <[email protected]>
Co-authored-by: Matěj Chalk <[email protected]>
Precondition:
Note
It looks rather chunky but 25 of the files are renaming a target and 5 files are deleted.
To make it easier to review I added comments for the deleted code blocks and their new location.
I also added excessive docs to help debug and explain the current situation.
I suggest starting with the
CONTRIBUTING.md
and then dive into the comments.This PR does not change the previous flow nor fixes bigger issues in the setup. It focuses on maintainability and documentation as well as good error handling and user feedback.
This PR includes:
verdaccio
folder and created plugin to add targets dynamicallynpm
folder and created plugin to add targets dynamicallynx npm-check <project-name> --pkgVersion=<version>
nx npm-install <project-name> --pkgVersion=<version> --registry=<registry> --tag=<tag>
nx npm-uninstall <project-name> --pkgVersion=<version> --registry=<registry> --tag=<tag>
npm
andpublish
folder and created plugins to add targets dynamicallynx npm-check <project-name> --pkgVersion=<version>
nx publish <project-name> --nextVersion=<version> --registry=<registry> --tag=<tag>
CONTRIBUTORS.md
with information on the current e2e processBefore:
nx e2e cli-e2e
global-setup.e2e.ts
tools/scripts/start-registry.ts
- one globally shared registrypublish.mjs
all packagesnpm install <package-name>
all packagesnpm uninstall <package-name>
all packagesAfter:
nx e2e cli-e2e
global-setup.e2e.ts
nx start-verdaccio
- one registry per e2e project but still one globally shared npm env (node_modules folder, npm config)nx publish <project-name>
all packagesnx npm-install <project-name>
all packagesnx npm-uninstall <project-name>
all packages