Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(utils): prioritize score in sort order #801

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Conversation

hanna-skryl
Copy link
Collaborator

Closes #571

This PR updates the order of checks from weight > score > value > title to score > weight > value > title to prioritize sorting by score. This change ensures that failed audits appear before passed ones in the report.

@hanna-skryl hanna-skryl self-assigned this Aug 20, 2024
@github-actions github-actions bot added 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🧩 utils labels Aug 20, 2024
Copy link

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared target commit dbf41c3 with source commit 85b3cdb.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🟡 50 🟡 57 ↑ +6.6
Code coverage 🟡 90 🟡 90 ↓ +0
Custom checks 🟡 67 🟡 67
Security 🟢 100 🟢 100
Updates 🟡 78 🟡 78
Accessibility 🟢 91 🟢 91
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Bug prevention 🟢 100 🟢 100
Code style 🟢 99 🟢 99
👍 1 group improved, 👎 1 group regressed, 👍 3 audits improved, 👎 2 audits regressed, 14 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🟡 50 🟡 57 ↑ +6.6
Code coverage Code coverage metrics 🟡 90 🟡 90 ↓ +0

18 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Largest Contentful Paint 🟨 3.5 s 🟨 2.7 s ↓ −24 %
Lighthouse First Contentful Paint 🟥 3.1 s 🟨 2.6 s ↓ −17 %
Lighthouse First Meaningful Paint 🟨 3.1 s 🟨 2.6 s ↓ −17 %
Lighthouse Speed Index 🟥 5.9 s 🟥 6.3 s ↑ +7 %
Code coverage Branch coverage 🟨 84.7 % 🟨 84.7 % ↓ +0 %
Lighthouse Eliminate render-blocking resources 🟥 Potential savings of 1,280 ms 🟥 Potential savings of 510 ms ↓ −61 %
Lighthouse Uses efficient cache policy on static assets 🟨 27 resources found 🟨 27 resources found ↓ +0 %
Lighthouse JavaScript execution time 🟥 8.1 s 🟥 7.7 s ↓ −6 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,804 KiB 🟩 Total size was 1,804 KiB ↓ +0 %
Lighthouse Minimizes main-thread work 🟥 16.8 s 🟥 17.1 s ↑ +2 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 106 KiB 🟥 Potential savings of 106 KiB ↓ −33 %
Lighthouse Server Backend Latencies 🟩 210 ms 🟩 90 ms ↓ −59 %
Lighthouse Total Blocking Time 🟥 4,900 ms 🟥 5,020 ms ↑ +2 %
Lighthouse Max Potential First Input Delay 🟥 2,440 ms 🟥 2,380 ms ↓ −2 %
Lighthouse Time to Interactive 🟥 14.4 s 🟥 14.4 s ↑ +0 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +0 %
Lighthouse Network Round Trip Times 🟩 20 ms 🟩 10 ms ↓ −58 %
Lighthouse Initial server response time was short 🟩 Root document took 360 ms 🟩 Root document took 370 ms ↑ +2 %
Lighthouse Avoids an excessive DOM size 🟥 2,213 elements 🟥 2,207 elements ↓ +0 %

491 other audits are unchanged.

@BioPhoton
Copy link
Collaborator

Nice one! The inpatient reader says thank you ☺️

@hanna-skryl hanna-skryl merged commit f8f6b74 into main Aug 21, 2024
31 checks passed
@hanna-skryl hanna-skryl deleted the utils-sort-order branch August 21, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🧩 utils
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugin list in md report is unsorted
3 participants