Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: update Nx 19 & other dependencies #811

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

build: update Nx 19 & other dependencies #811

wants to merge 9 commits into from
+9,795 −8,670

Conversation

vmasek
Copy link
Collaborator

@vmasek vmasek commented Sep 4, 2024 •
edited
Loading

closes #771
closes #776

@vmasek vmasek added the 🌊 Nx Nx related issues label Sep 4, 2024
@vmasek vmasek self-assigned this Sep 4, 2024
@vmasek
Copy link
Collaborator Author

vmasek commented Sep 4, 2024

Investigation of failing CI in progress 👀

@vmasek vmasek force-pushed the nx-19-update branch 4 times, most recently from f30595f to 6e16658 Compare September 5, 2024 18:27
@vmasek vmasek force-pushed the nx-19-update branch 3 times, most recently from cd2ca75 to b3dd03d Compare September 6, 2024 18:02
@github-actions github-actions bot removed the 🧩 core label Sep 6, 2024
@vmasek vmasek force-pushed the nx-19-update branch 2 times, most recently from 9218855 to b994b9f Compare September 6, 2024 18:45
@github-actions github-actions bot removed 📖 Project documentation improvements or additions to the project documentation 🧩 utils labels Sep 6, 2024
@github-actions github-actions bot removed the 🧩 cli label Oct 13, 2024
@github-actions github-actions bot added the 🦾 CI/CD continuous integration and deployment label Oct 14, 2024
@BioPhoton
Copy link
Collaborator

Ima run e2e in parallel is not a must have for this pr

BioPhoton
BioPhoton reviewed Nov 23, 2024
View reviewed changes
esbuild.config.js Outdated Show resolved Hide resolved
BioPhoton
BioPhoton reviewed Nov 23, 2024
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
BioPhoton
BioPhoton reviewed Nov 23, 2024
View reviewed changes
nx.json Outdated Show resolved Hide resolved
BioPhoton
BioPhoton requested changes Nov 23, 2024
View reviewed changes
Copy link
Collaborator

@BioPhoton BioPhoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found small left overs. Merging main will also remove a couple of changed files. Would be good to do that after #873 is in main.

@github-actions github-actions bot removed 🦾 CI/CD continuous integration and deployment 🧩 nx-plugin labels Nov 25, 2024
BioPhoton
BioPhoton reviewed Nov 26, 2024
View reviewed changes
e2e/nx-plugin-e2e/tests/plugin-create-nodes.e2e.test.ts
@@ -158,6 +158,7 @@ describe('nx-plugin', () => {
configurations: {},
executor: `@code-pushup/nx-plugin:cli`,
options: {},
parallelism: true,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to be expected there by the unit test result

@vmasek
Copy link
Collaborator Author

vmasek commented Nov 26, 2024

I am stuck on e2e failing, not really sure how to proceed. The logs in GH actions do not load but you can download them as zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BioPhoton BioPhoton BioPhoton requested changes

@matejchalk matejchalk Awaiting requested review from matejchalk matejchalk is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

@vmasek vmasek

Labels
🧩 eslint-plugin 🌊 Nx Nx related issues 🧩 nx-plugin 🔬 testing writing tests 🛠️ tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ci: migrate to Nx 19 reduce dependencies
2 participants
@vmasek @BioPhoton