Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix rollup versions #202

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

chore: Fix rollup versions #202

wants to merge 19 commits into from

Conversation

suejung-sentry
Copy link
Contributor

@suejung-sentry suejung-sentry commented Nov 15, 2024

Bump some remaining versions of rollup. Also use a more recent version of the rollup plugin in our build examples

Follows up to https://github.com/codecov/internal-issues/issues/931

@codecov-notifications
Copy link

codecov-notifications bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Components Coverage Δ
Plugin core 97.02% <ø> (ø)
Rollup plugin 10.81% <ø> (ø)
Vite plugin 11.02% <ø> (ø)
Webpack plugin 49.88% <ø> (ø)

📢 Thoughts on this report? Let us know!

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.06%. Comparing base (8f89fd4) to head (4f2ae9b).

✅ All tests successful. No failed tests found.

Additional details and impacted files
Components Coverage Δ
Plugin core 97.02% <ø> (ø)
Rollup plugin 10.81% <ø> (ø)
Vite plugin 11.02% <ø> (ø)
Webpack plugin 49.88% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-staging
Copy link

codecov-staging bot commented Nov 15, 2024

Bundle Report

Changes will increase total bundle size by 148.61kB (5.41%) ⬆️⚠️, exceeding the configured threshold of 5%.

Bundle name Size Change
@codecov/bundler-plugin-core-esm* 12.29kB 6 bytes (-0.05%) ⬇️
@codecov/nextjs-webpack-plugin-esm* 1.11kB 761 bytes (-40.59%) ⬇️
@codecov/webpack-plugin-cjs 4.47kB 57 bytes (1.29%) ⬆️
@codecov/sveltekit-plugin-esm* 1.09kB 198 bytes (22.22%) ⬆️⚠️
@codecov/webpack-plugin-esm* 3.36kB 6 bytes (0.18%) ⬆️
@codecov/solidstart-plugin-cjs-esm 1.09kB 1.09kB (100%) ⬆️⚠️
@codecov/rollup-plugin-cjs-esm-esm-esm-esm 1.3kB 1.3kB (100%) ⬆️⚠️
@codecov/solidstart-plugin-cjs-esm-esm-esm-esm 949 bytes 949 bytes (100%) ⬆️⚠️
@codecov/nuxt-plugin-cjs-esm-esm-esm-esm 830 bytes 830 bytes (100%) ⬆️⚠️
@codecov/nuxt-plugin-cjs-esm 1.23kB 1.23kB (100%) ⬆️⚠️
@codecov/vite-plugin-cjs-esm-esm 1.24kB 1.24kB (100%) ⬆️⚠️
@codecov/vite-plugin-cjs-esm 2.33kB 2.33kB (100%) ⬆️⚠️
@codecov/vite-plugin-cjs-esm-esm-esm-esm 1.24kB 1.24kB (100%) ⬆️⚠️
@codecov/bundle-analyzer-cjs-esm-esm-esm-esm 3.11kB 3.11kB (100%) ⬆️⚠️
@codecov/nextjs-webpack-plugin-cjs-esm-esm 1.11kB 1.11kB (100%) ⬆️⚠️
@codecov/remix-vite-plugin-cjs-esm-esm 957 bytes 957 bytes (100%) ⬆️⚠️
@codecov/bundler-plugin-core-cjs-esm-esm 12.29kB 12.29kB (100%) ⬆️⚠️
@codecov/remix-vite-plugin-cjs-esm-esm-esm 957 bytes 957 bytes (100%) ⬆️⚠️
@codecov/bundler-plugin-core-cjs-esm-esm-esm 12.29kB 12.29kB (100%) ⬆️⚠️
@codecov/remix-vite-plugin-cjs-esm-esm-esm-esm 957 bytes 957 bytes (100%) ⬆️⚠️
@codecov/bundler-plugin-core-cjs-esm-esm-esm-esm 12.29kB 12.29kB (100%) ⬆️⚠️
@codecov/bundle-analyzer-cjs-esm-esm 3.11kB 3.11kB (100%) ⬆️⚠️
@codecov/bundle-analyzer-cjs-esm-esm-esm 3.11kB 3.11kB (100%) ⬆️⚠️
@codecov/solidstart-plugin-cjs-esm-esm 949 bytes 949 bytes (100%) ⬆️⚠️
@codecov/solidstart-plugin-cjs-esm-esm-esm 949 bytes 949 bytes (100%) ⬆️⚠️
@codecov/sveltekit-plugin-cjs-esm-esm-esm-esm 891 bytes 891 bytes (100%) ⬆️⚠️
@codecov/nextjs-webpack-plugin-cjs-esm-esm-esm 1.11kB 1.11kB (100%) ⬆️⚠️
@codecov/nextjs-webpack-plugin-cjs-esm 1.88kB 1.88kB (100%) ⬆️⚠️
@codecov/remix-vite-plugin-cjs-esm 1.09kB 1.09kB (100%) ⬆️⚠️
@codecov/bundler-plugin-core-cjs-esm 53.15kB 53.15kB (100%) ⬆️⚠️
@codecov/vite-plugin-cjs-esm-esm-esm 1.24kB 1.24kB (100%) ⬆️⚠️
@codecov/sveltekit-plugin-cjs-esm-esm 891 bytes 891 bytes (100%) ⬆️⚠️
@codecov/sveltekit-plugin-cjs-esm-esm-esm 891 bytes 891 bytes (100%) ⬆️⚠️
@codecov/sveltekit-plugin-cjs-esm 1.09kB 1.09kB (100%) ⬆️⚠️
@codecov/webpack-plugin-cjs-esm 3.37kB 3.37kB (100%) ⬆️⚠️
@codecov/nuxt-plugin-cjs-esm-esm 830 bytes 830 bytes (100%) ⬆️⚠️
@codecov/rollup-plugin-cjs-esm 2.33kB 2.33kB (100%) ⬆️⚠️
@codecov/webpack-plugin-cjs-esm-esm 3.36kB 3.36kB (100%) ⬆️⚠️
@codecov/webpack-plugin-cjs-esm-esm-esm 3.36kB 3.36kB (100%) ⬆️⚠️
@codecov/webpack-plugin-cjs-esm-esm-esm-esm 3.36kB 3.36kB (100%) ⬆️⚠️
@codecov/rollup-plugin-cjs-esm-esm 1.3kB 1.3kB (100%) ⬆️⚠️
@codecov/nuxt-plugin-cjs-esm-esm-esm 830 bytes 830 bytes (100%) ⬆️⚠️
@codecov/rollup-plugin-cjs-esm-esm-esm 1.3kB 1.3kB (100%) ⬆️⚠️
@codecov/nextjs-webpack-plugin-cjs-esm-esm-esm-esm 1.11kB 1.11kB (100%) ⬆️⚠️
@codecov/bundle-analyzer-cjs-esm 3.45kB 3.45kB (100%) ⬆️⚠️

ℹ️ *Bundle size includes cached data from a previous commit

Copy link

codecov bot commented Nov 15, 2024

Bundle Report

Changes will increase total bundle size by 187.93kB (3.27%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
@codecov/vite-plugin-esm* 1.24kB 1.09kB (-46.82%) ⬇️
@codecov/bundler-plugin-core-esm* 53.11kB 40.82kB (332.13%) ⬆️
@codecov/rollup-plugin-esm* 1.3kB 1.03kB (-44.14%) ⬇️
@codecov/sveltekit-plugin-esm* 1.09kB 198 bytes (22.22%) ⬆️
@codecov/webpack-plugin-cjs 4.47kB 57 bytes (1.29%) ⬆️
@codecov/webpack-plugin-esm* 3.36kB 8 bytes (-0.24%) ⬇️
@codecov/solidstart-plugin-esm* 949 bytes 142 bytes (-13.02%) ⬇️
@codecov/example-sveltekit-app-client-esm 715.09kB 2 bytes (0.0%) ⬆️
@codecov/example-sveltekit-app-server-esm 974.29kB 1 bytes (0.0%) ⬆️
@codecov/solidstart-plugin-cjs-esm-esm 949 bytes 949 bytes (100%) ⬆️
@codecov/rollup-plugin-cjs-esm-esm-esm 1.3kB 1.3kB (100%) ⬆️
@codecov/solidstart-plugin-cjs-esm-esm-esm-esm 949 bytes 949 bytes (100%) ⬆️
@codecov/sveltekit-plugin-cjs-esm-esm 891 bytes 891 bytes (100%) ⬆️
@codecov/remix-vite-plugin-cjs-esm-esm-esm-esm 957 bytes 957 bytes (100%) ⬆️
@codecov/bundler-plugin-core-cjs-esm-esm-esm 12.29kB 12.29kB (100%) ⬆️
@codecov/bundle-analyzer-cjs-esm-esm-esm-esm 3.11kB 3.11kB (100%) ⬆️
@codecov/bundle-analyzer-cjs-esm-esm 3.11kB 3.11kB (100%) ⬆️
@codecov/remix-vite-plugin-cjs-esm-esm 957 bytes 957 bytes (100%) ⬆️
@codecov/nextjs-webpack-plugin-cjs-esm-esm-esm 1.11kB 1.11kB (100%) ⬆️
@codecov/webpack-plugin-cjs-esm-esm 3.36kB 3.36kB (100%) ⬆️
@codecov/nextjs-webpack-plugin-cjs-esm 1.88kB 1.88kB (100%) ⬆️
@codecov/nuxt-plugin-cjs-esm-esm 830 bytes 830 bytes (100%) ⬆️
@codecov/solidstart-plugin-cjs-esm 1.09kB 1.09kB (100%) ⬆️
@codecov/webpack-plugin-cjs-esm-esm-esm-esm 3.36kB 3.36kB (100%) ⬆️
@codecov/remix-vite-plugin-cjs-esm 1.09kB 1.09kB (100%) ⬆️
@codecov/rollup-plugin-cjs-esm 2.33kB 2.33kB (100%) ⬆️
@codecov/nextjs-webpack-plugin-cjs-esm-esm 1.11kB 1.11kB (100%) ⬆️
@codecov/vite-plugin-cjs-esm-esm-esm-esm 1.24kB 1.24kB (100%) ⬆️
@codecov/nuxt-plugin-cjs-esm-esm-esm 830 bytes 830 bytes (100%) ⬆️
@codecov/vite-plugin-cjs-esm-esm-esm 1.24kB 1.24kB (100%) ⬆️
@codecov/rollup-plugin-cjs-esm-esm-esm-esm 1.3kB 1.3kB (100%) ⬆️
@codecov/vite-plugin-cjs-esm-esm 1.24kB 1.24kB (100%) ⬆️
@codecov/bundler-plugin-core-cjs-esm-esm 12.29kB 12.29kB (100%) ⬆️
@codecov/sveltekit-plugin-cjs-esm-esm-esm-esm 891 bytes 891 bytes (100%) ⬆️
@codecov/webpack-plugin-cjs-esm 3.37kB 3.37kB (100%) ⬆️
@codecov/sveltekit-plugin-cjs-esm 1.09kB 1.09kB (100%) ⬆️
@codecov/bundler-plugin-core-cjs-esm-esm-esm-esm 12.29kB 12.29kB (100%) ⬆️
@codecov/bundle-analyzer-cjs-esm-esm-esm 3.11kB 3.11kB (100%) ⬆️
@codecov/webpack-plugin-cjs-esm-esm-esm 3.36kB 3.36kB (100%) ⬆️
@codecov/bundler-plugin-core-cjs-esm 53.15kB 53.15kB (100%) ⬆️
@codecov/nuxt-plugin-cjs-esm-esm-esm-esm 830 bytes 830 bytes (100%) ⬆️
@codecov/solidstart-plugin-cjs-esm-esm-esm 949 bytes 949 bytes (100%) ⬆️
@codecov/vite-plugin-cjs-esm 2.33kB 2.33kB (100%) ⬆️
@codecov/rollup-plugin-cjs-esm-esm 1.3kB 1.3kB (100%) ⬆️
@codecov/remix-vite-plugin-cjs-esm-esm-esm 957 bytes 957 bytes (100%) ⬆️
@codecov/nextjs-webpack-plugin-cjs-esm-esm-esm-esm 1.11kB 1.11kB (100%) ⬆️
@codecov/nuxt-plugin-cjs-esm 1.23kB 1.23kB (100%) ⬆️
@codecov/sveltekit-plugin-cjs-esm-esm-esm 891 bytes 891 bytes (100%) ⬆️
@codecov/bundle-analyzer-cjs-esm 3.45kB 3.45kB (100%) ⬆️

ℹ️ *Bundle size includes cached data from a previous commit

@suejung-sentry suejung-sentry changed the title chore: Fix rollup versions in lockfile chore: Fix rollup versions Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant