-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cpuallocator, plugins: handle priority as an option. #414
Conversation
48ab368
to
884af6e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Turn priority of CPUs to allocate/release into an opaque option passed to cpuallocator.{Allocate,Release}Cpus(). This should make it much easier to add new options to the allocator in the future. Signed-off-by: Krisztian Litkey <[email protected]>
Signed-off-by: Krisztian Litkey <[email protected]>
Signed-off-by: Krisztian Litkey <[email protected]>
Allow overriding the default allocation flags using the WithAllocFlags option. Signed-off-by: Krisztian Litkey <[email protected]>
884af6e
to
1e086a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@klihub, is this ready for merge, or are you planning to add some more With... options? |
@askervin Yes, I have already two in the pipeline stacked on this but I was planning to file those separately and this one just to pave the way for those. One a straightforward |
Turn priority of CPUs to allocate/release into an opaque option passed to
cpuallocator.{Allocate,Release}Cpus()
. This should make it much easier to add new options to the allocator in the future.