Don't change color inheritance for <hr> #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi :) I think you should remove the
color: inheritdeclaration from the <hr> element.The comment for this declaration makes it sound like it is fixing a bug only present in Firefox, but that is incorrect. None of the major browsers support inheritance by default, so there is no reason to include it in
normalize.css.I can understand why you might want it in
opinionated.css, since it feels intuitive that <hr> would inherit the text color, but unfortunately, Chromium browsers do not support color inheritance at all, so by adding it you are un-normalizing the styles because the color now will be different between browser engines.I made a test document and took some screenshots here: sindresorhus/modern-normalize#75