Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ResourcesRequest to v4 #106

Closed
wants to merge 1 commit into from

Conversation

ismarc
Copy link

@ismarc ismarc commented Apr 9, 2021

This adds support for the ResourcesRequest calls to v4 conjur
servers

What does this PR do?

Checklists

Change log

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR, and/or there is a follow-on issue to update docs, or
  • This PR does not require updating any documentation

This adds support for the ResourcesRequest calls to v4 conjur
servers
@ismarc ismarc requested a review from a team as a code owner April 9, 2021 21:39
@izgeri
Copy link
Contributor

izgeri commented Apr 12, 2021

@ismarc what is the use case for this going forward? We are announcing v4 deprecation in the next release (see #102) and will remove v4 support soon (though we can maintain it in a branch). Is there a time horizon when you won't still be using this? Are you consuming it as a dependency of another solution (like Summon)?

@ismarc
Copy link
Author

ismarc commented Apr 12, 2021

@ismarc what is the use case for this going forward? We are announcing v4 deprecation in the next release (see #102) and will remove v4 support soon (though we can maintain it in a branch). Is there a time horizon when you won't still be using this? Are you consuming it as a dependency of another solution (like Summon)?

We need to sync data from conjurops v4 to conjurops v5, and during the transition period will need to regularly be syncing variables. This change lets us enumerate the accessible variables in a v4 instance via the resource listing.

So long as there's a single version that has the support included, we can reference that version.

Copy link
Contributor

@izgeri izgeri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this probably needs a rebase against master before it can be merged - see the failing build (recent PR fixed it)

@@ -14,6 +14,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- New check in RetrieveBatchSecretSafe method which will return an error if the `Content-Type` header
is not set in the response (this indicates Conjur is out of date with the client).
[cyberark/conjur-api-go#104](https://github.com/cyberark/conjur-api-go/issues/104)
- ResourcesRequest is now supported for v4 conjur instances.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- ResourcesRequest is now supported for v4 conjur instances.
- ResourcesRequest is now supported for Conjur Enterprise v4.
[PR cyberark/conjur-api-go#106](https://github.com/cyberark/conjur-api-go/pull/106)

I am not sure whether it's worth including this since our next release soon will deprecate v4, so I'd also be ok with deleting it. up to you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants