-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement initial chocolatey packaging workflow #1400
base: master
Are you sure you want to change the base?
Conversation
df9034e
to
752f850
Compare
Signed-off-by: mikeee <[email protected]>
752f850
to
549f6fb
Compare
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
@dapr/maintainers-cli @dapr/approvers-cli please could you offer some thoughts on this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from a high-level and a cursory reading of the docs. Some comments.
<authors>The Dapr Authors</authors> | ||
<projectUrl>https://dapr.io/</projectUrl> | ||
<iconUrl>https://cdn.jsdelivr.net/gh/dapr/website/static/images/dapr.svg</iconUrl> | ||
<copyright>Copyright 2021 The Dapr Authors</copyright> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<copyright>Copyright 2021 The Dapr Authors</copyright> | |
<copyright>Copyright 2024 The Dapr Authors</copyright> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also provide scripts to uninstall and upgrade? (I understand this is a first implementation, shooting my ideas).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Chocolatey includes an autoinstaller - I've validated this works with the msi installer/uninstaller
# Update script url | ||
- name: Update install script url | ||
shell: pwsh | ||
run: Get-Content tools/chocolateyInstall.ps1 | foreach{$_.replace("dapr_cli_url", "https://github.com/dapr/cli/releases/download/v$env:DAPR_CLI_VERSION/dapr.msi")} | Set-Content -Path tools/chocolateyInstall.ps1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we change the tools directory to .github/choco/tools? This will be consistent with winget
.
- refactor choco dir - update copyright notice Signed-off-by: mikeee <[email protected]>
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
@dapr/maintainers-cli ping |
I'm in favor of this, let's try to get it merged this week |
Description
This implements an initial packaging workflow for pushing to the Chocolatey community repo when a release is tagged.
The
CHOCOLATEY_TOKEN
is required to be set prior to merging - available in the 1Password vault.Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #172
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: