Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scheduler: change /var/lock to /run/lock #1445

Open
wants to merge 28 commits into
base: release-1.14
Choose a base branch
from

Conversation

JoshVanL
Copy link
Contributor

Change the data directory from /var/lock to /run/lock so that the scheduler data directory also works for mariner based images.

Change the data directory from `/var/lock` to `/run/lock` so that the
scheduler data directory also works for mariner based images.

Signed-off-by: joshvanl <[email protected]>
@JoshVanL JoshVanL requested review from a team as code owners August 15, 2024 22:25
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 31 lines in your changes missing coverage. Please review.

Project coverage is 21.84%. Comparing base (e08443b) to head (fa652f9).
Report is 1 commits behind head on release-1.14.

Files with missing lines Patch % Lines
pkg/standalone/standalone.go 0.00% 31 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.14    #1445      +/-   ##
================================================
- Coverage         21.86%   21.84%   -0.02%     
================================================
  Files                40       40              
  Lines              4931     4935       +4     
================================================
  Hits               1078     1078              
- Misses             3772     3776       +4     
  Partials             81       81              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: joshvanl <[email protected]>
artursouza
artursouza previously approved these changes Aug 15, 2024
@artursouza
Copy link
Member

Tests are failing.

@dapr-bot
Copy link
Collaborator

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@dapr-bot dapr-bot added stale and removed stale labels Sep 18, 2024
@dapr-bot
Copy link
Collaborator

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@dapr-bot dapr-bot added stale and removed stale labels Oct 18, 2024
@dapr-bot
Copy link
Collaborator

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@dapr-bot dapr-bot added stale and removed stale labels Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants