Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding error handling to tag version creation #1470

Closed
wants to merge 1 commit into from

Conversation

edwardfward
Copy link

@edwardfward edwardfward commented Nov 22, 2024

Description

  • Added error handling for malformed release.Tagnames to prevent methods being called on nil cur receiver and subsequent panic.
  • Removed redundant import alias yaml
  • Errant release.tag_name vedge causing the issue appears to have been changed or been removed.
 "tag_name": "vedge",

Issue reference

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests (Not applicable)
  • Extended the documentation (Not applicable)

@edwardfward edwardfward changed the title adding error handling to tag version creation Adding error handling to tag version creation Nov 22, 2024
@edwardfward edwardfward marked this pull request as ready for review November 22, 2024 13:53
@edwardfward edwardfward requested review from a team as code owners November 22, 2024 13:53
@edwardfward
Copy link
Author

Changed merged in #1469

@edwardfward edwardfward deleted the version-panic-fix branch November 22, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant