Fixed typo which prevents the auto detection of certain wired adapters #918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great catch! Thank a lot!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since restructuring the code on Apr 14, 2023, there seems to be a small typo in BlueRetro/main/wired/detect.c which prevents the auto detection of certain HW1 wired adapters. The buggy line 34 currently looks like this:
if (io & BIT(detect_pin[i] - 32)) {In my opinion this should be
if (io & BIT(detect_pin[i] < 32 ? detect_pin[i] : detect_pin[i] - 32)) {or much simpler
if (io & BIT(detect_pin[i] & 31)) {