Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CARDS-2606: Improve delete dialog with long names #1846

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

CARDS-2606: Improve delete dialog with long names #1846

wants to merge 2 commits into from

Conversation

acrowthe
Copy link
Contributor

  • Remove entry name from delete dialog title
  • Split the entry name onto a new line for the first delete dialog
  • Add quotations around the entry name in the recursive deletion dialog
  • Add capitalization to enty label/type when it is the first word in a sentence

image
image

@acrowthe
CARDS-2606: Improve delete dialog with long names
962fd60 
- Remove entry name from delete dialog title
- Split the entry name onto a new line for the first delete dialog
- Add quotations around the entry name in the recursive deletion dialog
- Add capitalization to enty label/type when it is the first word in a sentence
@acrowthe
CARDS-2606: Improve delete dialog with long names
effaf90 
- Minor improvement to error text
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marta- marta- marta- left review comments

@sdumitriu sdumitriu sdumitriu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@acrowthe @sdumitriu @marta-