Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NodeVersion definition, make_semantic_model utility #11051

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

gshank
Copy link
Contributor

@gshank gshank commented Nov 25, 2024

Resolves #

Problem

Mashumaro 3.15 caused some breakages in our code.

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@gshank gshank requested a review from a team as a code owner November 25, 2024 23:02
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.80%. Comparing base (407f6ca) to head (524ce54).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11051      +/-   ##
==========================================
- Coverage   89.15%   87.80%   -1.35%     
==========================================
  Files         183      183              
  Lines       23765    23765              
==========================================
- Hits        21188    20868     -320     
- Misses       2577     2897     +320     
Flag Coverage Δ
integration 84.77% <100.00%> (-1.70%) ⬇️
unit 62.17% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.17% <100.00%> (ø)
Integration Tests 84.77% <100.00%> (-1.70%) ⬇️

@gshank gshank requested a review from a team as a code owner November 26, 2024 02:58
@gshank gshank requested review from jcserv and removed request for a team November 26, 2024 02:58
@cla-bot cla-bot bot added the cla:yes label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant