New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Add asv benchmark jobs to CI #234

Open

Illviljan wants to merge 48 commits into deepcharles:master from Illviljan:add_asv_benchmark_ci

Illviljan commented Jan 25, 2022 •

edited

Loading

Add a benchmarking ci, it will run if run-benchmark label is set.

Closes Add airspeed velocity benchmarks #231

Inspired by:

Illviljan and others added 10 commits

January 25, 2022 21:36


          Add asv benchmark and ci

80fdde9


          Update ruptures.py

3d3db47


          Update asv.conf.json

d29a8e8


          Update asv.conf.json

fc29500


          Update pyproject.toml

743ab76


          Revert "Update pyproject.toml"

9227b3a

This reverts commit 743ab76.


          Update __init__.py

52b7a35


          Update setup.py

efd2e76


          [pre-commit.ci] auto fixes from pre-commit.com hooks

7d206ce

for more information, see https://pre-commit.ci


          Update ruptures.py

c54dc3e

codecov bot commented Jan 25, 2022 •

edited

Loading

Codecov Report

Merging #234 (324c802) into master (42b1bc3) will not change coverage.
The diff coverage is n/a.

❗ Current head 324c802 differs from pull request most recent head dcdd3a3. Consider uploading reports for the commit dcdd3a3 to get more accurate results

@@           Coverage Diff           @@
##           master     #234   +/-   ##
=======================================
  Coverage   98.77%   98.77%           
=======================================
  Files          40       40           
  Lines         978      978           
=======================================
  Hits          966      966           
  Misses         12       12

Flag	Coverage Δ
unittests	`98.77% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42b1bc3...dcdd3a3. Read the comment docs.


          Merge branch 'add_asv_benchmark_ci' of https://github.com/Illviljan/r…

f18e1ac

…uptures into add_asv_benchmark_ci

Illviljan changed the title ~~Add asv benchmark ci~~ test: Add asv benchmark ci

Illviljan and others added 17 commits

January 27, 2022 20:32


          Update setup.py

f72cccc


          [pre-commit.ci] auto fixes from pre-commit.com hooks

001cc80

for more information, see https://pre-commit.ci


          Update pyproject.toml

2f103d3


          Merge branch 'add_asv_benchmark_ci' of https://github.com/Illviljan/r…

755a560

…uptures into add_asv_benchmark_ci


          figure out why cython is not imported instead

191dfdb


          [pre-commit.ci] auto fixes from pre-commit.com hooks

e2ea412

for more information, see https://pre-commit.ci


          Update benchmarks.yml

48f7e0c


          Merge branch 'add_asv_benchmark_ci' of https://github.com/Illviljan/r…

de508ac

…uptures into add_asv_benchmark_ci


          Update setup.py

c45e083


          [pre-commit.ci] auto fixes from pre-commit.com hooks

3a72c89

for more information, see https://pre-commit.ci


          Update setup.py

15c2999


          [pre-commit.ci] auto fixes from pre-commit.com hooks

c07ea33

for more information, see https://pre-commit.ci


          Update setup.py

7d37ead


          Merge branch 'add_asv_benchmark_ci' of https://github.com/Illviljan/r…

0cd9986

…uptures into add_asv_benchmark_ci


          Update setup.py

500b8cb


          Update setup.py

a383d66


          Update setup.py

f9b397e

Illviljan and others added 18 commits

January 28, 2022 21:00


          Update setup.py

5568dc6


          [pre-commit.ci] auto fixes from pre-commit.com hooks

25cd6b2

for more information, see https://pre-commit.ci


          Update setup.py

713fd3e


          [pre-commit.ci] auto fixes from pre-commit.com hooks

b361198

for more information, see https://pre-commit.ci


          Update setup.py

00ff39d


          Merge branch 'add_asv_benchmark_ci' of https://github.com/Illviljan/r…

baa87db

…uptures into add_asv_benchmark_ci


          [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci


          undo

924aa06


          Update asv.conf.json


          Merge branch 'add_asv_benchmark_ci' of https://github.com/Illviljan/r…

4e85624

…uptures into add_asv_benchmark_ci


          [pre-commit.ci] auto fixes from pre-commit.com hooks

2f168b4

for more information, see https://pre-commit.ci


          Update pyproject.toml

a511c72


          Update asv.conf.json

d5609e8


          Merge branch 'add_asv_benchmark_ci' of https://github.com/Illviljan/r…

86baad1

…uptures into add_asv_benchmark_ci


          Update ruptures.py

6b019e0


          Update benchmarks.yml

ae1e768


          Update ruptures.py

b0d54f0


          [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Illviljan commented

View reviewed changes

asv_bench/asv.conf.json

Comment on lines +60 to +66

+                  "matrix": {
+                      "setuptools": [""],
+                      "setuptools_scm[toml]": [""],
+                      "Cython": [""],
+                      "numpy": [""],
+                      "scipy": [""],
+                  },

Author

Illviljan Jan 28, 2022

All the required installs needs to be here as well.

Illviljan marked this pull request as ready for review

January 28, 2022 21:16

Author

Illviljan commented Jan 28, 2022

Ok this is ready for review now, it passes on my local fork at least Illviljan#1.
If you add the label run-benchmark the benchmark will run.

The benchmarks probably needs a bit more thought by someone more experienced. But that's for another PR I think.


          Remove unused code

324c802

Illviljan changed the title ~~test: Add asv benchmark ci~~ test: Add asv benchmark jobs to CI

deepcharles reviewed

View reviewed changes

.github/workflows/benchmarks.yml Outdated Show resolved Hide resolved


          Update .github/workflows/benchmarks.yml

dcdd3a3

Co-authored-by: Charles T. <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet