-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(validation)!: validation testing framework #667
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments as I look at general structure otherwise no major concerns.
Co-authored-by: Brandt Keller <[email protected]>
…ew-fields-process' into 460-validation-review-fields-process
Made a couple updates to incorporate the templating for dev commands work
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nearly finished with review - no major modifications noticed as of yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Developer Experience around the validation authoring process will be super important to influence. Appreciate where you took this.
Description
Initial work to specify Lula-native validation testing
inject
function totransform
- tried to do a bit of refactor to pull out functionality to support more granular testsRunTests
method to theLulaValidation
+ updated schema to supportdev validate
to handle--run-tests
flag, and because this was getting annoying to debug a--print-test-resources
that will print out the transformed resources.json to the validation directory -> This is basically just a print-to-screen implementation right now. Probably further discussion needed on dumping a test-result object or how we want to handle that.Follow-ups to this
dev validate
cmd to support the e2e testing structure we have--run-tests
tolula validate
-> will need to include some exploration/decision on how the test report gets dumpedRelated Issue
Fixes #460
Type of change
Checklist before merging