Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Poetry error message #852

Merged
merged 14 commits into from
Nov 21, 2024
Merged

Poetry error message #852

merged 14 commits into from
Nov 21, 2024

Conversation

prathameshzarkar9
Copy link
Contributor

Issue #845

infoOutput has been updated and logged the message of the command if the command fails inside container

image

@prathameshzarkar9 prathameshzarkar9 requested a review from a team as a code owner July 3, 2024 10:15
@prathameshzarkar9 prathameshzarkar9 mentioned this pull request Jul 3, 2024
Open
samruddhikhandale
samruddhikhandale requested changes Jul 3, 2024
View reviewed changes
src/spec-common/injectHeadless.ts Outdated Show resolved Hide resolved
src/test/configs/dockerfile-with-target/.devcontainer.json Outdated Show resolved Hide resolved
src/test/configs/example/.devcontainer.json Outdated Show resolved Hide resolved
src/test/configs/dockerfile-with-target/.devcontainer.json Outdated Show resolved Hide resolved
samruddhikhandale
samruddhikhandale requested changes Jul 5, 2024
View reviewed changes
src/spec-common/injectHeadless.ts Outdated Show resolved Hide resolved
src/test/cli.up.test.ts Outdated Show resolved Hide resolved
samruddhikhandale
samruddhikhandale previously requested changes Jul 8, 2024
View reviewed changes
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for another review from @chrmarti. Thanks!

src/spec-common/injectHeadless.ts Outdated Show resolved Hide resolved
chrmarti
chrmarti requested changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@chrmarti chrmarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment, maybe the error handling should move up a few lines. Thanks.

src/spec-common/injectHeadless.ts Outdated Show resolved Hide resolved
chrmarti
chrmarti requested changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@chrmarti chrmarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @prathameshzarkar9! I have left a few comments.

src/spec-common/injectHeadless.ts Outdated Show resolved Hide resolved
src/spec-common/injectHeadless.ts Outdated Show resolved Hide resolved
@prathameshzarkar9
Copy link
Contributor Author

prathameshzarkar9 commented Jul 25, 2024 •
edited
Loading

@chrmarti , can you please review the requested changes

chrmarti
chrmarti requested changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@chrmarti chrmarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more comments and some message polishing.

src/spec-common/injectHeadless.ts Show resolved Hide resolved
src/spec-common/injectHeadless.ts Outdated Show resolved Hide resolved
src/spec-common/injectHeadless.ts Outdated Show resolved Hide resolved
src/spec-common/injectHeadless.ts Outdated Show resolved Hide resolved
src/spec-common/injectHeadless.ts Outdated Show resolved Hide resolved
src/spec-common/injectHeadless.ts Outdated Show resolved Hide resolved
src/spec-common/injectHeadless.ts Outdated Show resolved Hide resolved
@samruddhikhandale
Copy link
Member

@prathameshzarkar9 Can you fix the failing tests? Thanks

@Mathiyarasy
Copy link

@chrmarti Could you please review this PR ..

@chrmarti chrmarti mentioned this pull request Nov 13, 2024
Closed
chrmarti
chrmarti requested changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@chrmarti chrmarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left two more comments.

src/spec-common/injectHeadless.ts Outdated Show resolved Hide resolved
src/spec-common/injectHeadless.ts Show resolved Hide resolved
@gauravsaini04 gauravsaini04 mentioned this pull request Nov 18, 2024
Closed
@chrmarti chrmarti dismissed samruddhikhandale’s stale review November 21, 2024 08:52

All comments were addressed.

@eljog eljog merged commit 7178ceb into devcontainers:main Nov 21, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samruddhikhandale samruddhikhandale samruddhikhandale left review comments

@eljog eljog eljog approved these changes

@chrmarti chrmarti chrmarti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@prathameshzarkar9 @samruddhikhandale @Mathiyarasy @chrmarti @eljog