cli issue - Valid devcontainer.metadata can corrupt compose override file #904 #928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eljog
reviewed
Nov 13, 2024
| @@ -557,7 +557,7 @@ while sleep 1 & wait $$!; do :; done", "-"${userEntrypoint.map(a => `, ${JSON.st | |||
| init: true` : ''}${user ? ` | |||
| user: ${user}` : ''}${Object.keys(env).length ? ` | |||
| environment:${Object.keys(env).map(key => ` | |||
| - ${key}=${env[key]}`).join('')}` : ''}${mergedConfig.privileged ? ` | |||
| - "${key}=${env[key].replace(/"/g, '\\"')}"`).join('')}` : ''}${mergedConfig.privileged ? ` | |||
There was a problem hiding this comment.
What would be the resulting value? Should we put the env[key] in quotes if the quotes the in the values are escaped.
Is it possible to add tests for this scenario?
There was a problem hiding this comment.
There are additional characters to escape in a double quoted string. I might be easier to use a single quoted string, though I'm not sure how a newline would be represented: https://www.yaml.info/learn/quote.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #904
Description
Changelog
src/spec-node/dockerCompose.tsfile's Line number 560, wrapped the key value pairs in double quotes so they be considered single entity, rather the : separating them into two entities earlier as discussed in the issue atROSCONSOLE_FORMAT: "[$${severity}] [$${walltime:%Y-%m-%d %H:%M:%S}] [$${node}]: $${message}"Checklist