Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove the use of the --short flag in kubectl version #2696

Merged
merged 2 commits into from
Aug 18, 2023

Conversation

lizardruss
Copy link
Collaborator

What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix

What does this pull request do? Which issues does it resolve? (use resolves #<issue_number> if possible)
resolves #2694

Please provide a short message that should be published in the DevSpace release notes
Fixed an issue where DevSpace ran the kubectl version command with the flag --short. This is depreciated in v1.28 of kubectl, so DevSpace would no longer deploy K8s manifests. We use the --output=json flag to standardise the kubectl version result across versions.

What else do we need to know?
Fixes ENG-1890

@netlify
Copy link

netlify bot commented Aug 16, 2023

Deploy Preview for devspace-docs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 764765d
🔍 Latest deploy log https://app.netlify.com/sites/devspace-docs/deploys/64de6f95d149d40008a66cdb
😎 Deploy Preview https://deploy-preview-2696--devspace-docs.netlify.app/docs/configuration/dev/connections/terminal
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@ThomasK33 ThomasK33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, minor remark about testing Kubernetes versions in addition to kubectl versions

uses: azure/setup-kubectl@v3
with:
version: ${{ matrix.kubectl_version }}

# Creates KinD with using k8s versions from the matrix above
- name: Set up kind with K8s version v1.22.4
uses: engineerd/[email protected]
with:
version: "v0.11.1"
image: kindest/node:v1.22.4

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably should also adjust the node image version to the kubectl version, in which case we should rename the matrix variable name to kubernetes version or just kubernetes.

Suggested change
image: kindest/node:v1.22.4
image: kindest/node:${{ matrix.kubectl_version }}

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This gets trickier, since KinD doesn't distribute all versions (v1.27.4 is not available for example), and also not all KinD images are compatible with newer versions. I'll give it a shot, but we may need to manage the versions separately.

@JoshInLisbon
Copy link

Thanks for the PR @lizardruss .

We were wondering when this might be merged + released in a stable version?

lizardruss and others added 2 commits August 17, 2023 15:05
Fixes ENG-1890

Signed-off-by: Russell Centanni <[email protected]>
Co-authored-by: JoshInLondon <[email protected]>
Co-authored-by: Martin Chatterton <[email protected]>
Signed-off-by: Russell Centanni <[email protected]>
Fixes ENG-1890

Signed-off-by: Russell Centanni <[email protected]>
@lizardruss lizardruss merged commit 45f987c into devspace-sh:main Aug 18, 2023
18 checks passed
@lizardruss
Copy link
Collaborator Author

@JoshInLisbon We will aim for a release next week.

@JoshInLisbon
Copy link

Hi @lizardruss, would it be possible to provide an update on when there might be a new stable release? At the moment I am using a locally produced binary of Devspace. I would like to be able to use a stable release again. This also impacts adoption among other developers.

@lizardruss
Copy link
Collaborator Author

@JoshInLisbon DevSpace v6.3.3 has been released and contains this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to deploy/dev after new kubectl version (1.27 => 1.28)
3 participants