fix: do not wait for initContainer to exit when it is a sidecar #2866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for devspace-docs canceled.Built without sensitive environment variables
|
nberlee
force-pushed
the
main
branch
4 times, most recently
from
67a5a35
to
7c629f4
Compare
lizardruss
requested changes
Jul 9, 2024
|
@lizardruss I fixed the golang linter issues and github actions have the correct golang version. However the e2e test fail for some reason, which I was not able to figure out. |
Signed-off-by: Nico Berlee <[email protected]>
fixes devspace-sh#2865 Signed-off-by: Nico Berlee <[email protected]>
Signed-off-by: Nico Berlee <[email protected]>
Signed-off-by: Nico Berlee <[email protected]>
Signed-off-by: Nico Berlee <[email protected]>
lizardruss
requested changes
Jul 26, 2024
Signed-off-by: Russell Centanni <[email protected]>
Signed-off-by: Russell Centanni <[email protected]>
Signed-off-by: Russell Centanni <[email protected]>
Signed-off-by: Russell Centanni <[email protected]>
lizardruss
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2865
What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)resolves #2865
Please provide a short message that should be published in the DevSpace release notes
Fixed an issue where DevSpace ...
waits for native sidecar containers (init container)
What else do we need to know?