Update patching guidelines #4759
Conversation
dotnet-issue-labeler
bot
added
area-patch-removal
| @@ -39,6 +39,9 @@ create one. | |||
| > git format-patch --zero-commit --no-signature -1 -o "$PATCH_DIR/<repo>" | |||
| > ``` | |||
|
|
|||
| **Note:** Please make sure there are no other already existing patches | |||
There was a problem hiding this comment.
Does this break synchronization? It has been necessary in the past.
There was a problem hiding this comment.
It breaks the synchronization, we've only had it once. Why would it be necessary?
There was a problem hiding this comment.
Why would it be necessary?
Historically there have been numerous times where a single file is touched by multiple patches. Patches are typically kept separate per the time they were made and their scope. This makes patch removal much easier as the backports flow in.
Can't get backport flow soon enough...
There was a problem hiding this comment.
In which order would the patches be applied? Alphabetically? I know that the one case I mention was one patch adding a file and another patching it
There was a problem hiding this comment.
alphabetically - that is why the numeric prefix is included in the guidelines.
No description provided.