Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't panic if chunked encoding contains no chunk length #52

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

bugadani
Copy link
Contributor

@bugadani bugadani commented Oct 24, 2023

If we read a newline in place of the chunk length, total_read is 0 and the subtraction for the \r check underflows. This PR fixes this issue.

@rmja rmja merged commit 2f71cc9 into drogue-iot:main Oct 24, 2023
1 check passed
@bugadani bugadani deleted the panic branch October 24, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants