Remove dependency on rimraf #517
Open
+14
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fs-extra was basically created to avoid having to install both mkdirp, rimraf etc, and is also already installed here, so we can avoid using both at the same time. This moves rimraf to devDependencies, since it's still conveniant for the local 'clean' and 'prepack' commands. At the same time, update to fs-extra 10.x, since it's lowest supported node version there is now still lower than the lowest supported version for patch-package, but has still introduced the option of using node's native fs.rm when available: https://github.com/jprichardson/node-fs-extra/blob/master/CHANGELOG.md (fs-extra 11.x only works on node 14.14+, while patch-package currently supports all 14.x versions)
|
just wanna add that rimraf throws a warn
|
GSS-Rishi
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fs-extra was basically created to avoid having to install both mkdirp, rimraf etc, and is also already installed here, so we can avoid using both at the same time.
This moves rimraf to devDependencies, since it's still conveniant for the local 'clean' and 'prepack' commands.
At the same time, update to fs-extra 10.x, since it's lowest supported node version there is now still lower than the lowest supported version for patch-package, but has still introduced the option of using node's native fs.rm when available:
https://github.com/jprichardson/node-fs-extra/blob/master/CHANGELOG.md
(fs-extra 11.x only works on node 14.14+, while patch-package currently supports all 14.x versions)