Add support for Proto field predicates when populating with custom ra… #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
just let me know if there's something wrong |
|
Looking into it. |
|
This isn't working, checking what needs to be done
|
dvgaba
reviewed
Jun 15, 2023
| @@ -210,4 +210,15 @@ void shouldUseCustomRandomizerForSubMessageWhenItsDefined() { | |||
| assertThat(protoInstance.hasEmbeddedMessage()).isTrue(); | |||
| assertThat(protoInstance.getEmbeddedMessage()).isEqualTo(customEmbeddedMessage); | |||
| } | |||
|
|
|||
| @Test | |||
| void shouldUseCustomProviderRegistryToFillFields(){ | |||
There was a problem hiding this comment.
IMO we need to add support for byType as well.
There was a problem hiding this comment.
will take a look, thanks for the feedback!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #33
Didn't work on the base repository as it involves exposing a property. Sorry it if was not the correct flow