Update PR template #14490
Open
Update PR template #14490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the changelog requirement from the review guidelines. Changelog entries will be created in the release process, with the exception of breaking changes. For breaking changes the message needs to be added within the PR. Adjusted the PR template with sections to indicate if breaking changes are present. Added hint that if there are breaking changes a changelog message is needed. Streamlined the pull request guide to link directly to the existing PR template. Added attribution field to PR template to make it easier to see during the release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
As discussed in the dev meeting:
Removed the changelog requirement from the review guidelines.
Changelog entries will be created in the release process, with the exception of breaking changes.
For breaking changes the message needs to be added within the PR.
Adjusted the PR template with sections to indicate if breaking changes are present.
Added hint that if there are breaking changes a changelog message is needed.
Streamlined the pull request guide to link directly to the existing PR template.
Added attribution field to PR template to make it easier to see during the release.
How to test
Follow-ups
Review checklist
Reminder for reviewers